dialog: translations

zulip · Sep 25, 2023 · 634cd43 · 634cd43
1 parent 8b94b29
commit 634cd43
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
@@ -75,6 +75,18 @@
   "@actionSheetShare":  {
     "description": "Label for share button on action sheet."
   },
+  "dialogButtonOK": "OK",
+  "@dialogButtonOK": {
+    "description": "Button label in generic dialogs to confirm."
+  },
+  "dialogButtonCancel": "Cancel",
+  "@dialogButtonCancel": {
+    "description": "Button label in generic dialogs to cancel."
+  },
+  "dialogButtonContinue": "Continue",
+  "@dialogButtonContinue": {
+    "description": "Button label in generic dialogs to continue."
+  },
   "lightboxCopyLinkTooltip": "Copy link",
   "@lightboxCopyLinkTooltip": {
     "description": "Tooltip in lightbox for the copy link action."

diff --git a/lib/widgets/dialog.dart b/lib/widgets/dialog.dart
@@ -1,4 +1,5 @@
 import 'package:flutter/material.dart';
+import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
 
 Widget _dialogActionText(String text) {
   return Text(
@@ -14,12 +15,12 @@ Widget _dialogActionText(String text) {
   );
 }
 
-// TODO(i18n): title, message, and action-button text
 Future<void> showErrorDialog({
   required BuildContext context,
   required String title,
   String? message,
 }) {
+  final zulipLocalizations = ZulipLocalizations.of(context);
   return showDialog(
     context: context,
     builder: (BuildContext context) => AlertDialog(
@@ -28,7 +29,7 @@ Future<void> showErrorDialog({
       actions: [
         TextButton(
           onPressed: () => Navigator.pop(context),
-          child: _dialogActionText('OK')),
+          child: _dialogActionText(zulipLocalizations.dialogButtonOK)),
       ]));
 }
 
@@ -39,6 +40,7 @@ void showSuggestedActionDialog({
   required String? actionButtonText,
   required VoidCallback onActionButtonPress,
 }) {
+  final zulipLocalizations = ZulipLocalizations.of(context);
   showDialog(
     context: context,
     builder: (BuildContext context) => AlertDialog(
@@ -47,9 +49,9 @@ void showSuggestedActionDialog({
       actions: [
         TextButton(
           onPressed: () => Navigator.pop(context),
-          child: _dialogActionText('Cancel')),
+          child: _dialogActionText(zulipLocalizations.dialogButtonCancel)),
         TextButton(
           onPressed: onActionButtonPress,
-          child: _dialogActionText(actionButtonText ?? 'Continue')),
+          child: _dialogActionText(actionButtonText ?? zulipLocalizations.dialogButtonContinue)),
       ]));
 }