make HISTORY_SUBSTRING_SEARCH_ENSURE_UNIQUE force search unique result #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sult with any state if HIST_IGNORE_ALL_DUPS zsh setting
…re is no dups in history, which is not true with SHARED_HISTORY and APPEND_HISTORY zsh options
|
I explain how this plugin works with APPEND_HISTORY and HIST_IGNORE_ALL_DUPS in this comment #19 (comment) |
|
How to reproduce:
In the end you got command twice. I dont find a way to get only unique results in this case without these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because HIST_IGNORE_ALL_DUPS cant actually remove all dups with APPEND_HISTORY, INC_APPEND_HISTORY and SHARED_HISTORY options, it is better to have this options actually "ensure" if history got only unique elements. It is better do that with any state of HIST_IGNORE_ALL_DUPS zsh setting