Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read yaml by configmgr #4069

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Read yaml by configmgr #4069

merged 6 commits into from
Nov 18, 2024

Conversation

Martin-Zeithaml
Copy link
Contributor

@Martin-Zeithaml Martin-Zeithaml commented Nov 5, 2024

Remove nodeJS dependency by removing read_yaml - same functionality done with configmgr.

  1. Quickly remove nodeJS dependency while wating for Migrate 'zwe init' actions to templated JCL #3718
  2. New shell function added
  3. Minimal changes to install command - this could be used by init too

Test

/zowe/bin: ./zwe install -c ./zowe.yaml -vv
===============================================================================
>> INSTALL ZOWE MVS DATA SETS

- read_yaml_configmgr process ./zowe.yaml and extract '.zowe.setup.dataset.prefix -> /zowe/setup/dataset/prefix'
  * Exit code: 0
  * Output:
    ZOWE.TEST
Create MVS data sets if they do not exist
Creating Zowe sample library - ZOWE.TEST.SZWESAMP
- tsocmd ALLOCATE NEW DA('ZOWE.TEST.SZWESAMP') dsntype(library) dsorg(po) recfm(f b) lrecl(80) unit(sysallda) space(15,15) tracks
  * Succeeded
  * Exit code: 0
  * Output:
    ALLOCATE NEW DA('ZOWE.TEST.SZWESAMP') dsntype(library) dsorg(po) recfm(f b) lrecl(80) unit(sysallda) space(15,15) tracks

...

Copy files/SZWESAMP/ZWEIAPF to ZOWE.TEST.SZWESAMP
- cp  -v ./ZWEIAPF //'ZOWE.TEST.SZWESAMP'
  * Succeeded
  * Exit code: 0
  * Output:
    ./ZWEIAPF -> ZOWE.TEST.SZWESAMP(ZWEIAPF): text

...

-------------------------------------------------------------------------------
>> Zowe MVS data sets are installed successfully.

Zowe installation completed. In order to use Zowe, you need to run "zwe init" command to initialize Zowe instance.
- Type "zwe init --help" to get more information.

You can also run individual init sub-commands: mvs, certificate, security, vsam, apfauth, and stc.
- Type "zwe init <sub-command> --help" (for example, "zwe init stc --help") to get more information.

Notes

Old bugs kept:

  • No check of e.g. --ds-prefix 1234
  • --allow-overwrite not needed if you delete SZWEEXEC
  • Special chars
  • And probably much more...

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Nov 5, 2024

build 6397 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11687356435

Copy link

github-actions bot commented Nov 5, 2024

Test workflow 5667 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4069/zowe-3.1.0-pr-4069-6397-20241105153401.pax
Running on machine: zzow10
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11687455380

@Martin-Zeithaml Martin-Zeithaml changed the title [TEST] Read yaml by configmgr Read yaml by configmgr Nov 12, 2024
Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Nov 14, 2024

build 6433 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11836581229

Copy link

github-actions bot commented Nov 14, 2024

Test workflow 5684 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4069/zowe-3.1.0-pr-4069-6433-20241114115606.pax
Running on machine: zzow10
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11836688911

@1000TurquoisePogs
Copy link
Member

This works, but, there's other occurrences of read_yaml that remain
For example, "zwe init mvs" fails.

I understand read_yaml currently covers cases in which the schema is not possible to use or good to use (such as, "zwe stop" really shouldnt require a schema)

I think all "zwe init" should use this new code.

@1000TurquoisePogs
Copy link
Member

Nevermind - I see you made a PR about that.

Copy link

github-actions bot commented Nov 15, 2024

build 6438 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11856052875

Copy link

github-actions bot commented Nov 15, 2024

Test workflow 5688 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4069/zowe-3.1.0-pr-4069-6438-20241115121823.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11856126654

Copy link

github-actions bot commented Nov 15, 2024

build 6439 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11857056265

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Nov 15, 2024

build 6440 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11857092612

Copy link

github-actions bot commented Nov 15, 2024

Test workflow 5689 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4069/zowe-3.1.0-pr-4069-6439-20241115132749.pax
Running on machine: zzow10
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11857141477

Copy link

github-actions bot commented Nov 15, 2024

Test workflow 5690 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4069/zowe-3.1.0-pr-4069-6440-20241115132943.pax
Running on machine: zzow11
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11857168524

Copy link

github-actions bot commented Nov 18, 2024

build 6449 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11892981294

Copy link

github-actions bot commented Nov 18, 2024

Test workflow 5696 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4069/zowe-3.1.0-pr-4069-6449-20241118130749.pax
Running on machine: zzow10
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11893111955

@1000TurquoisePogs 1000TurquoisePogs merged commit 30d2e0d into v3.x/staging Nov 18, 2024
12 checks passed
@1000TurquoisePogs 1000TurquoisePogs deleted the v3.x/readYaml branch November 18, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants