Zwe install typescript version [DO NOT MERGE]

[Martin-Zeithaml]

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

• Tests for the changes have been added (for bug fixes / features)
• Necessary documentation (if appropriate) have been added / updated
• DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

• Bugfix
• Feature
• Other... Please describe:

Relevant issues

Fixes:

• zwe install --allow-overwrite not working as expected #3622
• zwe install clarification of behavior #3632
• zwe command does not handle parameters* #3645
• bin/libs/zos-dataset.ts: tsoCommand and dollar sign in dataset name #3648

Changes proposed in this PR

• zwe install is currently in shell version only
• This PR fixes the current version and introducing typescript version
• Based on existing help --dataset-prefix has priority
  • --dataset-prefix and zowe.yaml -> zowe.yaml ignored

Does this PR introduce a breaking change?

• Yes
• No, but I am not sure

Does this PR do something the person installing Zowe should know about?

Yes 😄
The shell version was some how working because of lucky bug, but these times are over and (hopefully) it will work as intended.

Tests

Because of change in zos-datasets.sh, following commands/libs must be tested:

• copy_to_data_set
  • zwe install
  • libs/components
  • libs/certificate
  • zwe init mvs
  • zwe init stc
  • zwe init vsam
  • zwe init security
• data_set_copy_to_data_set
  • zwe init mvs
  • zwe init stc

[github-actions]

PAX build 3940 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6642003541

[github-actions]

Test workflow 3440 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.12.0-PR-3635/zowe-2.12.0-pr-3635-3940-20231025144344.pax
Running on machine: zzow03
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6642110871

[github-actions]

PAX build 3946 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6653635379

[github-actions]

Test workflow 3446 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-3946-20231026115608.pax
Running on machine: zzow04
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6653702724

[github-actions]

PAX build 3947 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6654094099

[github-actions]

PAX build 3955 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6667411610

[github-actions]

Test workflow 3456 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-3955-20231027125512.pax
Running on machine: zzow03
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6667490549

[github-actions]

PAX build 3956 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6667573553

[github-actions]

Test workflow 3457 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-3956-20231027130856.pax
Running on machine: zzow04
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6667657453

[github-actions]

Test workflow 3457 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-3956-20231027130856.pax
Running on machine: zzow04
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6667657453

[github-actions]

PAX build 3962 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6690583286

[github-actions]

PAX build 3963 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6690604464

[github-actions]

Test workflow 3462 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-3963-20231030091837.pax
Running on machine: zzow03
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6690700291

[github-actions]

Test workflow 3463 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-3962-20231030092023.pax
Running on machine: zzow03
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6690719253

[github-actions]

Test workflow 3492 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-3990-20231106124400.pax
Running on machine: zzow02
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6770902486

[struga0258]

getting the following error when running zwe init certificate now:

bash-4.3$ zwe init certificate -c /u/ssuser1/zowe/runtime/zowe.yaml
Error ZWEL0106E: Value for '--common-name' parameter is required.

[github-actions]

PAX build 3999 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6798242087

[github-actions]

PAX build 3999 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6798242087

[Martin-Zeithaml]

Good catch @struga0258 !
The zwe init certificate at some point calls zwecli_inline_execute_command certificate keyring-jcl generate..., which calls zwe again, but with different parameters.
The condition, which I have added to prevent shift error, is causing this. I will remove or change this condition.

[github-actions]

PAX build 4004 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6813089782

[github-actions]

PAX build 4004 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6813089782

[github-actions]

Test workflow 3519 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-4004-20231113084945.pax
Running on machine: zzow02
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6847644202

[github-actions]

Test workflow 3522 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-4004-20231113084945.pax
Running on machine: zzow03
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6861641446

[github-actions]

PAX build 4026 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6866048725

[github-actions]

Test workflow 3525 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-4026-20231114155614.pax
Running on machine: zzow02
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6866157809

[github-actions]

Test workflow 3529 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-4026-20231114155614.pax
Running on machine: zzow02
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6873941455

[github-actions]

Test workflow 3529 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-4026-20231114155614.pax
Running on machine: zzow02
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6873941455

[github-actions]

Test workflow 3530 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3635/zowe-2.13.0-pr-3635-4026-20231114155614.pax
Running on machine: zzow03
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6874796389

[Martin-Zeithaml]

Testing

• Couple tests written in Zowe Quick JS
• Some tests are intentionally skipped
• Also testing the missing value bug and $ sign in dataset name/member bug

[ 1/40] [expected rc=102, result rc=102]: /zowe/bin/zwe install --ds-prefix "'UsEr.ZoWe.X#'"
[ 2/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --ds-prefix "UsEr.ZoWe.X#"
[ 3/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --ds-prefix "UsEr.ZoWe.X#"
[ 4/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install
[ 5/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --ds-prefix 'UsEr.ZoWe.X#' --allow-overwrite
[ 6/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --config ./zowe.yaml
[ 7/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --config "FILE(zowe.yaml)" --allow-overwrite
[ 8/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --ds-prefix 'UsEr.ZoWe.X#' --config 'FILE(./zowe.yaml)' --allow-overwrite
[ 9/40] [expected rc=102, result rc=102]: /zowe/bin/zwe install --ds-prefix '1ZOWE.INSTALL.here!' -c zowe.yaml
[10/40] [expected rc=102, result rc=102]: /zowe/bin/zwe install --ds-prefix 'UsEr.ZoWe.X#' --c asdfasdfasdfasdfasdfa.yaml
[11/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --ds-prefix 'UsEr.ZoWe.X#' -c asdfasdfasdfasdfasdfa.yaml
[12/40] [expected rc=100, result rc=100]: /zowe/bin/zwe -h
[13/40] [expected rc=102, result rc=102]: /zowe/bin/zwe install --ds-prefix
[14/40] [expected rc=108, result rc=108]: /zowe/bin/zwe install --config
[15/40] [expected rc=102, result rc=102]: /zowe/bin/zwe install --configmgr --ds-prefix
[16/40] [expected rc=108, result rc=108]: /zowe/bin/zwe install --configmgr --config
[17/40] [expected rc=108, result rc=108]: /zowe/bin/zwe install --configmgr
[18/40] [skipping the test             ]: /zowe/bin/zwe install -c 'PARMLIB(ZOWE.PARMLIB(YAML@))'
[19/40] [skipping the test             ]: /zowe/bin/zwe install -c 'PARMLIB(ZOWE.PARMLIB(YAML#))'
[20/40] [skipping the test             ]: /zowe/bin/zwe install -c 'PARMLIB(ZOWE.PARMLIB(YAML$))'
[21/40] [expected rc=102, result rc=102]: /zowe/bin/zwe install --ds-prefix "'UsEr.ZoWe.X#'" --configmgr
[22/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --ds-prefix "UsEr.ZoWe.X#" --configmgr
[23/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --ds-prefix "UsEr.ZoWe.X#" --configmgr
[24/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --configmgr
[25/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --ds-prefix 'UsEr.ZoWe.X#' --allow-overwrite --configmgr
[26/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --config ./zowe.yaml --configmgr
[27/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --config "FILE(zowe.yaml)" --allow-overwrite --configmgr
[28/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --ds-prefix 'UsEr.ZoWe.X#' --config 'FILE(./zowe.yaml)' --allow-overwrite --configmgr
[29/40] [expected rc=102, result rc=102]: /zowe/bin/zwe install --ds-prefix '1ZOWE.INSTALL.here!' -c zowe.yaml --configmgr
[30/40] [expected rc=102, result rc=102]: /zowe/bin/zwe install --ds-prefix 'UsEr.ZoWe.X#' --c asdfasdfasdfasdfasdfa.yaml --configmgr
[31/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install --ds-prefix 'UsEr.ZoWe.X#' -c asdfasdfasdfasdfasdfa.yaml --configmgr
[32/40] [expected rc=100, result rc=100]: /zowe/bin/zwe -h --configmgr
[33/40] [skipping the test             ]: /zowe/bin/zwe install --ds-prefix --configmgr
[34/40] [skipping the test             ]: /zowe/bin/zwe install --config --configmgr
[35/40] [skipping the test             ]: /zowe/bin/zwe install --configmgr --ds-prefix --configmgr
[36/40] [skipping the test             ]: /zowe/bin/zwe install --configmgr --config --configmgr
[37/40] [skipping the test             ]: /zowe/bin/zwe install --configmgr --configmgr
[38/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install -c 'PARMLIB(ZOWE.PARMLIB(YAML@))' --configmgr
[39/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install -c 'PARMLIB(ZOWE.PARMLIB(YAML#))' --configmgr
[40/40] [expected rc=  0, result rc=  0]: /zowe/bin/zwe install -c 'PARMLIB(ZOWE.PARMLIB(YAML$))' --configmgr