Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Port fix for Open with Encoding quickpick #3377

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Dec 27, 2024

Proposed changes

Ports #3253 to v2-lts branch

Release Notes

Milestone:

Changelog: Fixed an issue where "Open with Encoding" menu failed when tagged encoding was selected for a binary USS file

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

@t1m0thyj t1m0thyj changed the title Port fix for Open with Encoding quickpick [v2] Port fix for Open with Encoding quickpick Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (cf55928) to head (6fa6955).

Additional details and impacted files
@@           Coverage Diff           @@
##           v2-lts    #3377   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files         105      105           
  Lines       11161    11161           
  Branches     2367     2451   +84     
=======================================
  Hits        10426    10426           
  Misses        734      734           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Thanks for porting!

And I guess it doesn't make sense to "port" the UssFSProvider changes, since that's not a v2 thing 😋

Copy link

sonarqubecloud bot commented Jan 2, 2025

@zFernand0 zFernand0 merged commit ea61af9 into v2-lts Jan 2, 2025
9 checks passed
@zFernand0 zFernand0 deleted the v2/port-uss-encoding-fix branch January 2, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants