Add new settings for default dataset & job sort orders #3369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As a daily user of Zowe Explorer, I have found it annoying that the default sort order for datasets and jobs is never the one I want. Therefore, the following two new settings are added:
zowe.ds.default.sort
zowe.jobs.default.sort
The new settings use the same defaults as is currently hardcoded for datasets and jobs.
The "(default)" added to the side of the sort order method is no longer hardcoded and is changed based on the settings.
Why do the setting have to be edited in settings.json? Because the alternatives (I thought of) are:
Another change that could be made, is to add sort order per dataset, and for jobs, as a persistence, like favourites. I actually started doing this as the first iteration of the feature, but realised the default settings would be easier to do at first, then try persistence, as it seems a bit more complex. Let me know what the thoughts on that are.
Release Notes
Milestone: todo
Changelog: todo
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments
This is my first contribution to this project. I have read as much of the contributor guidelines as I can, but there is a lot, so I'm sorry if I've forgotten or missed something. It also means that naturally I am still learning the codebase, so changes may be sub-par. Therefore, I have decided to open this as a draft PR with no test cases written yet. This isn't in the roadmap nor any issue has been raised, so I'd like to make sure the team is ok with this existing at all.
Lastly, I feel like my development iteration experience is too manual and that I must be missing something/doing something wrong. Currently, when I am making changes, I have
pnpm watch:zowe-explorer
script running. To build, I dopnpm install && pnpm run package
. Then I go to extensions -> install from VSIX -> select zowe explorer. Then I must restart vscode (luckily it only takes a few seconds). When I want to look at debug logs, I need to manually open\.vscode\extensions\zowe.vscode-extension-for-zowe-3.1.0-SNAPSHOT\logs
, which I also have to close (and not be in the folder in file explorer) for vscode to actually install the new VSIX file. What am I missing?