Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix(uss): Support "Pull from Mainframe" w/ binary files #3362

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Dec 12, 2024

Proposed changes

Fixes #3355

Release Notes

Milestone: 2.18.1

Changelog:

  • Fixed an issue where binary USS files were not fetched using the "Pull from Mainframe" context menu option. #3355

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (935129e) to head (2f0b46b).
Report is 1 commits behind head on v2-lts.

Additional details and impacted files
@@           Coverage Diff           @@
##           v2-lts    #3362   +/-   ##
=======================================
  Coverage   93.39%   93.39%           
=======================================
  Files         105      105           
  Lines       11134    11134           
  Branches     2452     2363   -89     
=======================================
  Hits        10399    10399           
  Misses        734      734           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traeok traeok marked this pull request as ready for review December 12, 2024 16:15
Copy link

📅 Suggested merge-by date: 12/26/2024

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Thanks for porting! 🙏

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @traeok for porting the fix

@JillieBeanSim JillieBeanSim merged commit 1defee6 into v2-lts Dec 12, 2024
24 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/v2/pull-binary-files branch December 12, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants