Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix(uss): Opening file in tree causes focus to abruptly change #3350

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Dec 9, 2024

Proposed changes

Fixes #2486

ZE-ScrollAfterOpeningUSS

How to test

  1. Search for a USS directory under one of your profiles containing a lot of files
  2. Scroll to a point in the list where files take up the entire space in the USS tree
  3. Click on a file at the top of the list and start scrolling immediately
  4. Notice that the tree no longer snaps to the item you last clicked, and the file is opened in the editor

In v2.18.0, scrolling after clicking a file results in the tree snapping back to the selected item.

Release Notes

Milestone: 2.18.1

Changelog:

  • Fixed an issue where clicking on a file in the Unix System Services tree caused the tree to abruptly change focus to the selected item. #2486

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

@traeok traeok marked this pull request as ready for review December 9, 2024 15:00
@traeok traeok added this to the v2.18.1 milestone Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (1defee6) to head (c51f5ce).
Report is 1 commits behind head on v2-lts.

Additional details and impacted files
@@            Coverage Diff             @@
##           v2-lts    #3350      +/-   ##
==========================================
- Coverage   93.39%   93.39%   -0.01%     
==========================================
  Files         105      105              
  Lines       11134    11133       -1     
  Branches     2344     2450     +106     
==========================================
- Hits        10399    10398       -1     
  Misses        734      734              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traeok traeok changed the title fix(uss): Opening file in tree causes focus to abruptly change [v2] fix(uss): Opening file in tree causes focus to abruptly change Dec 9, 2024
JillieBeanSim
JillieBeanSim previously approved these changes Dec 12, 2024
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for this fix @traeok

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit d7f1903 into v2-lts Dec 12, 2024
18 checks passed
@zFernand0 zFernand0 deleted the fix/uss/snap-after-open branch December 12, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Scrolling in tree while a USS file is opening causes "snap" back to opened item
3 participants