Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support multi-select for "Add to Workspace" feature #3325

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Nov 18, 2024

Proposed changes

Resolves #3324

Release Notes

Milestone: 3.1.0

Changelog:

  • Added multi-select support for the "Add to Workspace" feature in Data Sets and USS. #3324

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

@traeok traeok marked this pull request as draft November 18, 2024 15:58
@traeok traeok linked an issue Nov 18, 2024 that may be closed by this pull request
@traeok traeok added this to the v3.1.0 milestone Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.99%. Comparing base (d5dc428) to head (fa3cbac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3325   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         116      116           
  Lines       12044    12046    +2     
  Branches     2770     2760   -10     
=======================================
+ Hits        11200    11202    +2     
  Misses        842      842           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 18, 2024
@traeok traeok marked this pull request as ready for review November 18, 2024 16:27
Copy link

📅 Suggested merge-by date: 12/2/2024

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion to edit the changelog

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @traeok

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
thanks for adding multi-select support for this 🙏

Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @traeok

@traeok traeok merged commit 57db6f3 into main Nov 19, 2024
33 of 34 checks passed
@traeok traeok deleted the feat/add-to-workspace-multiselect branch November 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Add to workspace using multi-select
5 participants