-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky integration tests and error handling for invalid team config #3322
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3322 +/- ##
==========================================
+ Coverage 92.99% 93.02% +0.03%
==========================================
Files 116 116
Lines 12046 12046
Branches 2656 2773 +117
==========================================
+ Hits 11202 11206 +4
+ Misses 842 839 -3
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
📅 Suggested merge-by date: 12/4/2024 |
There is another integration test ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me, thanks @t1m0thyj for the fix
Can re-approve if needed. The UpdateCredentials test is interesting because it tries to click on the search "action button" and Selenium times out stating that the search button isn't interactable.
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding Codicon handling to the QuickPick
page object 😋
Signed-off-by: Timothy Johnson <[email protected]>
77bf81f
to
592f01d
Compare
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
afe0c62
to
73cf33a
Compare
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks for adding the resources dir and for fixing these issues!
Looks like the Show Config dialog had regressed at some time after #3274, as I tested w/ the merge commit from that PR and it is working as expected 😅 it might have been related to some of the preliminary changes introduced recently for handling credential management.
@@ -564,7 +565,8 @@ export class ProfilesUtils { | |||
await ProfilesUtils.readConfigFromDisk(true); | |||
ZoweLogger.info(vscode.l10n.t("Zowe profiles initialized successfully.")); | |||
} catch (err) { | |||
if (err instanceof imperative.ImperativeError) { | |||
// JSON parsing errors in team config files will have suppressDump=true | |||
if (err instanceof imperative.ImperativeError && !err.mDetails.suppressDump) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creative workaround for the instanceof imperative.ImperativeError
check 😋
I think this makes more sense than just showing the error for all imperative errors
Proposed changes
Fix transient errors in integration tests, and upload test results in CI even when tests fail to make debugging easier.
The tests passed 10 times in a row in this workflow:
https://github.com/zowe/zowe-explorer-vscode/actions/runs/11923838338/job/33234787006
Also fixes error handling for an invalid team config file when ZE initializes, which was uncovered by fixing tests. In v3.0.3 the error notification was shown twice, and in the main branch ZE was failing to activate.
Release Notes
Milestone: 3.1.0
Changelog: Fixed an issue during initialization where the error dialog shown for a broken team configuration file was missing the "Show Config" action
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments