-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): prompt optimizations for create file/dir; address case of skipping prompt #3192
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
📅 Suggested merge-by date: 10/21/2024 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2-lts #3192 +/- ##
==========================================
+ Coverage 93.32% 93.35% +0.02%
==========================================
Files 105 105
Lines 11079 11081 +2
Branches 2304 2405 +101
==========================================
+ Hits 10340 10345 +5
+ Misses 738 735 -3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! 😋
Signed-off-by: Trae Yelovich <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @traeok
Proposed changes
Create Directory
andCreate File
USS features would appear even when a path is already set for the profile or parent folder. #3183Create Directory
andCreate File
features would continue processing when the first prompt was dismissed, causing an incorrect path to be generated. #3183Create Directory
andCreate File
features would incorrectly handle user-specified locations with trailing slashes. #3183Release Notes
Milestone: 2.18.1
Changelog: See
Proposed changes
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment