Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): prompt optimizations for create file/dir; address case of skipping prompt #3192

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Oct 7, 2024

Proposed changes

  • Fixed an issue where the location prompt for the Create Directory and Create File USS features would appear even when a path is already set for the profile or parent folder. #3183
  • Fixed an issue where the Create Directory and Create File features would continue processing when the first prompt was dismissed, causing an incorrect path to be generated. #3183
  • Fixed an issue where the Create Directory and Create File features would incorrectly handle user-specified locations with trailing slashes. #3183

Release Notes

Milestone: 2.18.1

Changelog: See Proposed changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Signed-off-by: Trae Yelovich <[email protected]>
@traeok traeok marked this pull request as ready for review October 7, 2024 12:44
Copy link

github-actions bot commented Oct 7, 2024

📅 Suggested merge-by date: 10/21/2024

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.35%. Comparing base (d090118) to head (a0a086e).
Report is 1 commits behind head on v2-lts.

Additional details and impacted files
@@            Coverage Diff             @@
##           v2-lts    #3192      +/-   ##
==========================================
+ Coverage   93.32%   93.35%   +0.02%     
==========================================
  Files         105      105              
  Lines       11079    11081       +2     
  Branches     2304     2405     +101     
==========================================
+ Hits        10340    10345       +5     
+ Misses        738      735       -3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zFernand0
zFernand0 previously approved these changes Oct 7, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 😋

packages/zowe-explorer/src/uss/actions.ts Outdated Show resolved Hide resolved
packages/zowe-explorer/src/uss/actions.ts Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Oct 7, 2024

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @traeok

@JillieBeanSim JillieBeanSim merged commit 29d09ff into v2-lts Oct 7, 2024
17 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/v2/create-dir branch October 7, 2024 21:16
@JillieBeanSim JillieBeanSim added this to the v2.18.1 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants