Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.22.9 release #3176

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Prepare 1.22.9 release #3176

merged 5 commits into from
Oct 14, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Oct 3, 2024

Proposed changes

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Timothy Johnson <[email protected]>
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @t1m0thyj
left small comment

@@ -1,5 +1,9 @@
# Change Log

## TBD Release

### Bug fixes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we want a CHANGELOG item for FTP ext too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see one for the previous 1.22.8 release but don't mind adding one since updating the ZE API package impacts the FTP extension 😋

Signed-off-by: Timothy Johnson <[email protected]>
traeok
traeok previously approved these changes Oct 7, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Timothy for preparing this release!

@JillieBeanSim JillieBeanSim self-requested a review October 7, 2024 13:19
JillieBeanSim
JillieBeanSim previously approved these changes Oct 7, 2024
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @t1m0thyj for preparing our last v1-lts release! 🎉

zFernand0
zFernand0 previously approved these changes Oct 7, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@t1m0thyj t1m0thyj dismissed stale reviews from zFernand0, JillieBeanSim, and traeok via 3ca7852 October 11, 2024 14:09
Copy link

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (e06cbfe) to head (3ca7852).
Report is 19 commits behind head on v1-lts.

Additional details and impacted files
@@           Coverage Diff           @@
##           v1-lts    #3176   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files          61       61           
  Lines        6325     6325           
  Branches     1195     1195           
=======================================
  Hits         5425     5425           
  Misses        892      892           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Timothy for the OVSX fix

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit 824ab64 into v1-lts Oct 14, 2024
26 of 27 checks passed
@zFernand0 zFernand0 deleted the update-v1-lts branch October 14, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants