fix(list): Do not fetch directory URIs in stat

[traeok]

Proposed changes

There was an oversight when implementing the remote lookup functionality for Data Sets and USS. The stat implementations should never make an API call unless we are explicitly fetching the URI with the fetch query, or if the entry is a file (stat is called for files open in the editor).

Considering this causes a balloon in API calls when listing data sets and USS folders, it would be best to get this fix into the upcoming pre-release, or at the very least get the fix merged before v3 GA so that our users don't encounter this problem 😅

How to test:
NOTE: Please test on a dev LPAR as this may spam the mainframe with API calls
List a large data set in Zowe Explorer. In this PR it will load very quickly - in the last pre-release it will take quite some time to complete (or it won't finish loading at all)

Release Notes

Milestone: vNext

Changelog:

• Fixed issue where listing data sets or USS files would cause a drastic increase in API calls, causing delays or a complete halt in Zowe Explorer.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (6bc3179) to head (3c5c3a5).
Report is 17 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #3093      +/-   ##
==========================================
+ Coverage   92.73%   92.77%   +0.03%     
==========================================
  Files         113      113              
  Lines       11566    11608      +42     
  Branches     2553     2572      +19     
==========================================
+ Hits        10726    10769      +43     
+ Misses        838      837       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📅 Suggested merge-by date: 9/20/2024

[zFernand0]

Changes make sense to me! 🙏🏽
Thanks for addressing the issue so quickly! 🥳
LGTM! 😋

[zFernand0]

LGTM! 😋

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[JillieBeanSim]

This works great and solves the hang mentioned on call last week retrieving data set members. Thanks @traeok for the fix!