Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0 Pre-release Aug 2024 #3057

Merged
merged 13 commits into from
Aug 30, 2024
Merged

3.0.0 Pre-release Aug 2024 #3057

merged 13 commits into from
Aug 30, 2024

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Aug 21, 2024

Proposed changes

Prepare v3 pre-release with breaking changes

Release Notes

Milestone: 3.0.0 pre-release

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim JillieBeanSim self-assigned this Aug 21, 2024
@t1m0thyj t1m0thyj linked an issue Aug 22, 2024 that may be closed by this pull request
Signed-off-by: Billie Simmons <[email protected]>
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (c72d346) to head (aff8da8).
Report is 16 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3057      +/-   ##
==========================================
- Coverage   92.87%   92.87%   -0.01%     
==========================================
  Files         112      112              
  Lines       11505    11504       -1     
  Branches     2520     2456      -64     
==========================================
- Hits        10685    10684       -1     
  Misses        818      818              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JillieBeanSim JillieBeanSim marked this pull request as ready for review August 23, 2024 12:39
@JillieBeanSim
Copy link
Contributor Author

Making ready for review, wiki updates don't affect the release but will work on making sure it's updated. @t1m0thyj would you mind pushing a CHANGELOG for PR's breaking change please?

@t1m0thyj
Copy link
Member

Making ready for review, wiki updates don't affect the release but will work on making sure it's updated. @t1m0thyj would you mind pushing a CHANGELOG for PR's breaking change please?

I plan to open a quick PR against vNext branch to fix an issue we found with "Log out of authentication service", and will update the changelog too 🙂

Signed-off-by: Billie Simmons <[email protected]>
@zFernand0 zFernand0 requested review from traeok and zFernand0 August 27, 2024 14:27
zFernand0
zFernand0 previously approved these changes Aug 27, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should run the pnpm update-sdks script to get the audit fixed before we merge this PR 😋

LGTM! 😋

Signed-off-by: zFernand0 <[email protected]>
zFernand0
zFernand0 previously approved these changes Aug 27, 2024
Signed-off-by: zFernand0 <[email protected]>
zFernand0
zFernand0 previously approved these changes Aug 27, 2024
@JillieBeanSim
Copy link
Contributor Author

I pushed up a quick fix that is a part of #3067 - since the fix will be merged regardless of which PR goes in first, no need to open a separate PR 😋

we can push another pre-release before and after the code freeze, sounds like there may be a few more breaking changes 😄

zFernand0
zFernand0 previously approved these changes Aug 29, 2024
traeok
traeok previously approved these changes Aug 30, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. Thanks @JillieBeanSim for preparing the pre-release


Do we want to go ahead and merge this, or do we want to get an additional 1-2 reviews?
Personally, I'm okay with merging and moving forward with the pre-release, but it might help to get an extra tester to verify that the pre-release is working smoothly across our dev machines. I personally didn't encounter any issues, but haven't exhausted every feature's use case during testing.

t1m0thyj
t1m0thyj previously approved these changes Aug 30, 2024
@zFernand0 zFernand0 dismissed stale reviews from t1m0thyj, traeok, and themself via b50c626 August 30, 2024 16:55
@traeok
Copy link
Member

traeok commented Aug 30, 2024

I noticed some strange issues with the conflict management. I've made a PR with the conflict fixes and its out and ready for review. We should try to get this into this pre-release so users don't run into any issues with the current conflict behavior. Sorry for the last-minute PR 😓 #3085

Copy link

@traeok traeok merged commit 7f36ebe into next Aug 30, 2024
28 checks passed
@traeok traeok deleted the 3.0.0-pre-release.20240821 branch August 30, 2024 18:06
Copy link

Release failed for the next branch. 😢

Error: The process '/opt/hostedtoolcache/node/18.20.4/x64/bin/pnpm' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/vsce.js:974:21)
    at ExecState.CheckComplete (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/vsce.js:960:16)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/vsce.js:863:21)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

Check the workflow run for more error details.

Powered by Octorelease 🚀

Copy link

Release failed for the next branch. 😢

Error: The process '/opt/hostedtoolcache/node/18.20.4/x64/bin/pnpm' failed with exit code 254
    at ExecState._setResult (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/vsce.js:974:21)
    at ExecState.CheckComplete (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/vsce.js:960:16)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/vsce.js:863:21)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

Check the workflow run for more error details.

Powered by Octorelease 🚀

Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

issue updating credentials in v3 pre-release
4 participants