Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mustache import for webviews #3038

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Fix mustache import for webviews #3038

merged 2 commits into from
Aug 2, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Aug 2, 2024

Proposed changes

Fixes regression introduced in #3023 where Edit History webview fails to open when debugging ZE:

Release Notes

Milestone: N/A

Changelog: N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

The fix was inspired by janl/mustache.js#786 (comment) 😋

Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Aug 2, 2024
@t1m0thyj t1m0thyj marked this pull request as draft August 2, 2024 16:46
Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj force-pushed the fix/trim-mustache-v3 branch from a2779b4 to 17a3ccc Compare August 2, 2024 19:10
Copy link

sonarqubecloud bot commented Aug 2, 2024

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (266a9a5) to head (17a3ccc).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3038    +/-   ##
========================================
  Coverage   92.87%   92.87%            
========================================
  Files         107      107            
  Lines       10913    10913            
  Branches     2253     2366   +113     
========================================
  Hits        10135    10135            
  Misses        776      776            
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj marked this pull request as ready for review August 2, 2024 19:16
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, opened a few webviews with this fix and its working as intended. Thanks @t1m0thyj 😋

@t1m0thyj t1m0thyj merged commit 4f44706 into next Aug 2, 2024
29 checks passed
@t1m0thyj t1m0thyj deleted the fix/trim-mustache-v3 branch August 2, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants