-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port(v2): Unsaved confirmation dialog for "Open with Encoding" feature #2911
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
packages/zowe-explorer/__tests__/__unit__/dataset/DatasetTree.unit.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
+ Coverage 93.48% 93.49% +0.01%
==========================================
Files 104 104
Lines 10869 10892 +23
Branches 2264 2272 +8
==========================================
+ Hits 10161 10184 +23
Misses 707 707
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @traeok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @traeok
Signed-off-by: Billie Simmons <[email protected]>
Quality Gate passedIssues Measures |
Proposed changes
Backport of the confirmation dialog shown for "Open with Encoding" when trying to change the encoding on an unsaved file.
Note: currently this only reverts the active editor. I'm still looking for a solution that will allow us to revert an editor that isn't active but is open - if anyone is aware of one please let me know 😋
In v3 we use the
vscode.window.tabGroups
approach to look for an editor in all open tabs, but this is not supported for VS Code versions older than v1.65.Release Notes
Milestone: 2.17.0
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executed