Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port(v2): Unsaved confirmation dialog for "Open with Encoding" feature #2911

Merged
merged 9 commits into from
May 13, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented May 10, 2024

Proposed changes

Backport of the confirmation dialog shown for "Open with Encoding" when trying to change the encoding on an unsaved file.

Note: currently this only reverts the active editor. I'm still looking for a solution that will allow us to revert an editor that isn't active but is open - if anyone is aware of one please let me know 😋

In v3 we use the vscode.window.tabGroups approach to look for an editor in all open tabs, but this is not supported for VS Code versions older than v1.65.

Release Notes

Milestone: 2.17.0

Changelog:

  • Added a confirmation dialog when the encoding is changed for an unsaved data set or USS file. #2911

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found

Signed-off-by: Trae Yelovich <[email protected]>
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (4ad11e9) to head (21b9bc1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
+ Coverage   93.48%   93.49%   +0.01%     
==========================================
  Files         104      104              
  Lines       10869    10892      +23     
  Branches     2264     2272       +8     
==========================================
+ Hits        10161    10184      +23     
  Misses        707      707              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anaxceron
anaxceron previously approved these changes May 10, 2024
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @traeok!

zFernand0
zFernand0 previously approved these changes May 13, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
image

@JillieBeanSim JillieBeanSim added this to the v2.17.0 milestone May 13, 2024
@JillieBeanSim JillieBeanSim dismissed stale reviews from zFernand0 and anaxceron via fcc05cd May 13, 2024 16:36
JillieBeanSim
JillieBeanSim previously approved these changes May 13, 2024
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @traeok

Signed-off-by: Billie Simmons <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@traeok traeok merged commit 8755004 into main May 13, 2024
20 checks passed
@traeok traeok deleted the port/confirm-dialogs branch May 13, 2024 19:38
@t1m0thyj t1m0thyj mentioned this pull request May 22, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants