-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit JCL enhancements #2510
Submit JCL enhancements #2510
Conversation
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
the duplication is from the test file, I cut it down a lot but not as low as sonar cloud wants, 3%. |
Signed-off-by: Billie Simmons <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @JillieBeanSim!
Signed-off-by: Billie Simmons <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this, but will this be a regression on available functionality?
We may be forcing users to install an extension, even though they used to be able to submit any file as a JCL job 😋
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for allowing any languageID to be submitted as JCL.
LGTM! 😋
Signed-off-by: Billie Simmons <[email protected]>
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Proposed changes
Added check for languageId to be jcl and added right click menu on local JCL in VSC file explorer and local JCL open in text editor to bring more awareness of the functionality available to submit local JCL using ZE.
Release Notes
Milestone: 2.12.0
Changelog:
Submit JCL
to local JCL files in VS Code file explorer as well as JCL opened in the VS Code text editor. #2475Zowe Explorer: Submit JCL
by adding a check for chosen profile returned to continue the action and added check on the language id for JCL. #1625 - UPDATED EXISTING TO INCLUDE LANGUAGE CHECKTypes of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments