Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit JCL enhancements #2510

Merged
merged 16 commits into from
Oct 24, 2023
Merged

Submit JCL enhancements #2510

merged 16 commits into from
Oct 24, 2023

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Oct 10, 2023

Proposed changes

Added check for languageId to be jcl and added right click menu on local JCL in VSC file explorer and local JCL open in text editor to bring more awareness of the functionality available to submit local JCL using ZE.

Screen Shot 2023-10-10 at 9 28 24 AM
Screen Shot 2023-10-10 at 9 27 03 AM

Release Notes

Milestone: 2.12.0

Changelog:

  • Added new right-click action for Submit JCL to local JCL files in VS Code file explorer as well as JCL opened in the VS Code text editor. #2475
  • Fixed submitting local JCL using command pallet option Zowe Explorer: Submit JCL by adding a check for chosen profile returned to continue the action and added check on the language id for JCL. #1625 - UPDATED EXISTING TO INCLUDE LANGUAGE CHECK

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim JillieBeanSim added this to the v2.12.0 milestone Oct 10, 2023
@JillieBeanSim JillieBeanSim self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
packages/zowe-explorer/src/dataset/actions.ts 94.19% <100.00%> (+0.41%) ⬆️
packages/zowe-explorer/src/dataset/init.ts 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@JillieBeanSim JillieBeanSim marked this pull request as ready for review October 17, 2023 18:51
@JillieBeanSim
Copy link
Contributor Author

JillieBeanSim commented Oct 17, 2023

the duplication is from the test file, I cut it down a lot but not as low as sonar cloud wants, 3%.

Signed-off-by: Billie Simmons <[email protected]>
traeok
traeok previously approved these changes Oct 19, 2023
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JillieBeanSim!

traeok
traeok previously approved these changes Oct 20, 2023
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this, but will this be a regression on available functionality?
We may be forcing users to install an extension, even though they used to be able to submit any file as a JCL job 😋

packages/zowe-explorer/src/dataset/actions.ts Outdated Show resolved Hide resolved
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for allowing any languageID to be submitted as JCL.
LGTM! 😋

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
21.3% 21.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rudyflores rudyflores merged commit 10ab3f8 into main Oct 24, 2023
23 of 24 checks passed
@rudyflores rudyflores deleted the submit-jcl-enhancements branch October 24, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run a job from local JCL (from main Explorer View on Primary sidebar)
4 participants