Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing webviews to vsix bundle #2500

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Add missing webviews to vsix bundle #2500

merged 2 commits into from
Oct 9, 2023

Conversation

rudyflores
Copy link
Contributor

@rudyflores rudyflores commented Oct 6, 2023 •
edited
Loading

Proposed changes

Add missing webview package to .vsix bundle in order to not break webviews in future 2.12.0 release after making updates to webview structure against main

Release Notes

Milestone: v2.12.0

Changelog: Add missing webview package to .visx bundle

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

@rudyflores rudyflores added this to the v2.12.0 milestone Oct 6, 2023
@rudyflores rudyflores self-assigned this Oct 6, 2023
@rudyflores rudyflores added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JillieBeanSim JillieBeanSim merged commit 79cd411 into main Oct 9, 2023
14 checks passed
@JillieBeanSim JillieBeanSim deleted the add-webview-to-bundle branch October 9, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traeok traeok traeok approved these changes

@JillieBeanSim JillieBeanSim JillieBeanSim approved these changes

@t1m0thyj t1m0thyj Awaiting requested review from t1m0thyj

@zFernand0 zFernand0 Awaiting requested review from zFernand0

Assignees

@rudyflores rudyflores

Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rudyflores @JillieBeanSim @traeok @zFernand0