Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Coverity issue and use local ZE API in samples #2490

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix Coverity issue and use local ZE API in samples #2490

merged 2 commits into from
Oct 2, 2023

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Oct 2, 2023

  • Fixes a code smell flagged by Coverity in ZoweDatasetNode.ts
  • Updates samples to reference ZE API with a symlink, so that Samples CI workflow will test for breaking changes to API

@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 2, 2023
@t1m0thyj
Build ZE API in samples workflow
2a21496 
Signed-off-by: Timothy Johnson <[email protected]>
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts 95.65% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

traeok
traeok approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t1m0thyj

@t1m0thyj t1m0thyj merged commit 18c221b into main Oct 2, 2023
15 checks passed
@t1m0thyj t1m0thyj deleted the fix-code-smells branch October 2, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traeok traeok traeok approved these changes

@awharn awharn awharn approved these changes

@zFernand0 zFernand0 Awaiting requested review from zFernand0

@JillieBeanSim JillieBeanSim Awaiting requested review from JillieBeanSim

@rudyflores rudyflores Awaiting requested review from rudyflores

Assignees
No one assigned
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t1m0thyj @awharn @traeok