-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of webview code #2489
Refactor of webview code #2489
Conversation
Signed-off-by: Rudy Flores <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
FYI: the code smell is from existing |
Signed-off-by: Rudy Flores <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rudyflores!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the sudden change in review @rudyflores. I was under the impression that the dev host was showing the latest changes, but the watch
script seems to be failing for me:
Signed-off-by: Rudy Flores <[email protected]>
…for-zowe into refactor-webviews
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
All fixed now @traeok good catch on the windows end of things for concurrently! |
Proposed changes
Refactor of existing Webview code to be easily extensible, this also integrates a watcher that will hot reload your changes on your webview to the debugger so you can see your changes just by saving!
To add new views in the future just:
zowe-explorer/src/webviews/src
.index.html
,app.tsx
,index.tsx
,types.ts
(optional)And that's it!
Release Notes
Milestone: 2.12.0
Changelog: Added new method of creating webviews on Zowe Explorer
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments