-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tree,jobs): Various fixes to improve tree UX; add checks for "Delete Job" #2481
Conversation
…& fix paste refresh Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems exactly the same as the PR below:
Also, thanks for adding JCLLIB to the appendSuffix
method 😋
I'm running into a small issue in the dataset tree with the ID already being registered.
Steps:
- Search for a dataset pattern, e.g.
sys1.parmlib
- Collapse the profile
- Expand the profile
- See this issue:
Everything else LGTM! 😋
@zFernand0 Yeah... 😅 I ran into some issues with the previous branch when trying to rebase off of maintenance, so figured a new branch/PR would be the quickest solution.
I haven't made any adjustments to the |
Signed-off-by: Trae Yelovich <[email protected]>
a9a8407
to
acf134e
Compare
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
a8c9844
to
e38ff9e
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Thanks for fixing the DS issue (and adding the license header on some test files) 😋
Proposed changes
This PR resolves the following issues:
pasteUss
function, and fixed refresh after paste is complete (nodes now show up as expected)JCLLIB
toappendSuffix
function to format its members as JCLRelease Notes
Milestone: 2.11.1
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments
If possible, please try to break the USS tree when testing this PR 😅 I want to make sure that the nodes are staying up to date, and I'm not sure that I've exhausted all scenarios. Here's what I've tested so far: