Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to change tag of uss file #2470

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Add option to change tag of uss file #2470

merged 9 commits into from
Sep 27, 2023

Conversation

rudyflores
Copy link
Contributor

@rudyflores rudyflores commented Sep 19, 2023

Proposed changes

Solves #2113

Added support for changing file tags on USS files, the new react code features:

  • conditional rendering for directories/files specifically for this new edit option
  • will show NOT SUPPORTED if the API for getTag() is not implemented by extender

New API in Zowe Explorer API was added: getTag()

Screenshots

Supported Tag view on z/OSMF
Screenshot 2023-09-20 at 2 58 54 PM

Opening a Directory hides the tag view
Screenshot 2023-09-20 at 3 01 17 PM

If tag is not supported it will show NOT SUPPORTED and is also not editable or clickable
Screenshot 2023-09-20 at 3 02 17 PM

Release Notes

Milestone: 2.12.0

Changelog: Added option for changing tags on USS files

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

@rudyflores rudyflores self-assigned this Sep 19, 2023
@rudyflores rudyflores added this to the v2.12.0 milestone Sep 19, 2023
@rudyflores rudyflores linked an issue Sep 19, 2023 that may be closed by this pull request
@rudyflores
Copy link
Contributor Author

Keeping this in draft for the time being! currently writing some unit tests but once those are ready this should be ready to be reviewed!

@rudyflores rudyflores marked this pull request as ready for review September 20, 2023 18:57
@codecov
Copy link

codecov bot commented Sep 20, 2023

@rudyflores
Copy link
Contributor Author

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 2 Code Smells

No Coverage information No Coverage information 0.0% 0.0% Duplication

FYI the code smells are from tests mocking the @zowe/cli call for Utilities, this doesn't need to be addressed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks and works great! To test:

  • I saved some ASCII data in an untagged file, then changed it to the EBCDIC tag (IBM-1047)
  • Used "Pull from Mainframe", noticed the garbled characters once pulled down
  • Changed the tag back to ISO-8859-1, used "Pull from Mainframe" again
  • Verified that the ASCII data matched what I saved before changing tags

Thanks @rudyflores!

@rudyflores rudyflores merged commit fd0649f into main Sep 27, 2023
@rudyflores rudyflores deleted the change-file-tags-ui branch September 27, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support for changing file tags within Zowe Explorer
3 participants