-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to change tag of uss file #2470
Conversation
Signed-off-by: Rudy Flores <[email protected]>
Keeping this in draft for the time being! currently writing some unit tests but once those are ready this should be ready to be reviewed! |
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
…n-for-zowe into change-file-tags-ui
This reverts commit 8bc51c8. Signed-off-by: Rudy Flores <[email protected]>
4f1e8cd
to
d5754ba
Compare
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
FYI the code smells are from tests mocking the |
Signed-off-by: Rudy Flores <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks and works great! To test:
- I saved some ASCII data in an untagged file, then changed it to the EBCDIC tag (IBM-1047)
- Used "Pull from Mainframe", noticed the garbled characters once pulled down
- Changed the tag back to ISO-8859-1, used "Pull from Mainframe" again
- Verified that the ASCII data matched what I saved before changing tags
Thanks @rudyflores!
Proposed changes
Solves #2113
Added support for changing file tags on USS files, the new react code features:
NOT SUPPORTED
if the API forgetTag()
is not implemented by extenderNew API in Zowe Explorer API was added:
getTag()
Screenshots
Supported Tag view on z/OSMF
Opening a Directory hides the tag view
If tag is not supported it will show
NOT SUPPORTED
and is also not editable or clickableRelease Notes
Milestone: 2.12.0
Changelog: Added option for changing tags on USS files
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments