Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ftp/ds): ECONNRESET FTPS error for empty dataset contents #2460

Merged
merged 11 commits into from
Sep 20, 2023

Conversation

traeok
Copy link
Member

@traeok traeok commented Sep 12, 2023

Proposed changes

When trying to upload or create an empty data set member in an FTP profile while secureFtp is enabled, an ECONNRESET error occurs from the FTP client that zos-node-accessor uses. This PR avoids this error by substituting blank contents with a single space.

See zos-node-accessor/#93 for more info.

Release Notes

Milestone: 2.12.0

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found

@traeok traeok force-pushed the fix/ftp/create-member branch from 47d6865 to 98cf361 Compare September 12, 2023 17:50
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Current head 845e7d3 differs from pull request most recent head 3e24aab. Consider uploading reports for the commit 3e24aab to get more accurate results

Files Changed Coverage
...xplorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts 100.00%

📢 Thoughts on this report? Let us know!.

@JTonda JTonda added this to the v2.12.0 milestone Sep 14, 2023
JillieBeanSim
JillieBeanSim previously approved these changes Sep 15, 2023
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @traeok

@traeok
Copy link
Member Author

traeok commented Sep 19, 2023

Turns out that this fix is only needed if secureFtp is enabled for a specific profile. I've adjusted the logic so we only use this fix if secureFtp == true.

@traeok traeok changed the title fix(ftp/ds): ECONNRESET FTP error for empty dataset contents fix(ftp/ds): ECONNRESET FTPS error for empty dataset contents Sep 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

I don't think its related to this PR, but when testing the FTP extension I saw this popup several times. Is anyone else seeing this behavior?
image

@JillieBeanSim JillieBeanSim merged commit a449d97 into main Sep 20, 2023
20 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/ftp/create-member branch September 20, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequently unable to create a new PDS member using the FTP Plugin in VSCode
5 participants