-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ftp/ds): ECONNRESET FTPS error for empty dataset contents #2460
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
47d6865
to
98cf361
Compare
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @traeok
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Turns out that this fix is only needed if |
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
I don't think its related to this PR, but when testing the FTP extension I saw this popup several times. Is anyone else seeing this behavior?
Proposed changes
When trying to upload or create an empty data set member in an FTP profile while
secureFtp
is enabled, an ECONNRESET error occurs from the FTP client thatzos-node-accessor
uses. This PR avoids this error by substituting blank contents with a single space.See zos-node-accessor/#93 for more info.
Release Notes
Milestone: 2.12.0
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executed