Migrate from yarn to pnpm

[rudyflores]

Proposed changes

Migrate to new package manager PNPM for improved install and build times for development vs Yarn

Release Notes

Milestone: v3.0

Changelog: Changed Yarn package manager to PNPM package manager.

Testing this PR

For testing this PR perform the following:

• run pnpm i
• run pnpm build
• run pnpm package
• run pnpm test
• run pnpm fresh-clone (this one uses the new concurrency feature!)
• try running any npm or yarn command (this should throw an error since only pnpm commands are allowed)

Make sure to test normal ZE functionality in the dev host as well as packaged extension to make sure everything is in order as well :)

Metrics

fresh-clone command:

Yarn

PNPM

install command:

Yarn

PNPM

package command:

Yarn

PNPM

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Further comments

[awharn]

I have a couple of questions

[rudyflores]

@traeok I think the samples packages in our repo should be maybe just moved to its own repository? otherwise we should define it in the pnpm-workspaces.yaml which will cause it to bundle and install when running pnpm i && pnpm build.

This is also why you see the check for the samples fail too

[traeok]

@rudyflores We can definitely discuss moving the samples in tomorrow's stand-up - if we add more samples in the future, we are probably better off having a separate repo, so I'm in favor of that 👍

[t1m0thyj]

Thanks @rudyflores! pnpm commands are running nice and fast for me locally.

[JillieBeanSim]

this all LGTM! thanks @rudyflores for all of the hard work that went into this change. If all are on board for pnpm, then so am I 😄 . With the amount of changes this introduces into the next branch it will be easier for PRs raised against main or maintenance to have another PR with same work possibly cherry-picked against next to avoid the conflicts that will come from the differences between the branches.

[traeok]

LGTM, thanks @rudyflores! pnpm is definitely quicker, looking forward to using it instead of yarn 🎉

[zFernand0]

What Trae said 👆🏽
LGTM! 😋

[awharn]

I only have one comment about this PR, as the rest of this looks fantastic. Would anyone be against removing --parallel from the test script, and adding a test:parallel script? I only ask because the test data is getting mixed between packages, and personally, it becomes a little bit harder to track what is going wrong, and where.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication