Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ze(uss): Pulling from mainframe status bar message does not get disposed of for binary files #3355

Closed
Tracked by #3166
zFernand0 opened this issue Dec 11, 2024 · 3 comments · Fixed by #3356
Closed
Tracked by #3166
Assignees
Labels
bug Something isn't working severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases
Milestone

Comments

@zFernand0
Copy link
Member

zFernand0 commented Dec 11, 2024

Describe the bug

The status bar message doesn't go away when you open a USS file as binary and then pull from mainframe
image

To Reproduce

  1. Open a USS file as binary (via the open with encoding option)
  2. Right click on the same file and Pull from mainframe
  3. Notice the status bar message not getting disposed of.
    image

Expected behavior

For the message to go away eventually 😋

Screenshots

image

Desktop (please complete the following information):

  • OS: All
  • Zowe Explorer Version: 3.0.3
  • (Optional) Zowe CLI Version: N/A
  • (Optional) Are you using Secure Credential Store? N/A

Additional context

Found while looking for a Download option for USS files and Dataset.
Thanks @roman-kupriyanov


Since the node's contextValue is binaryFile, the SharedContext.isDocument() doesn't consider it as a valid document. Thus we remove it from the list.
image

I think we just need to dispose of the status message outside the for-loop
image

@zFernand0 zFernand0 added bug Something isn't working severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases labels Dec 11, 2024
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@zFernand0 zFernand0 added the good first issue Good for newcomers label Dec 11, 2024
@traeok traeok linked a pull request Dec 11, 2024 that will close this issue
15 tasks
@traeok
Copy link
Member

traeok commented Dec 12, 2024

Turns out that Pull from Mainframe never supported binary USS files. I'm going to address this in v2 as well.

@traeok traeok removed good first issue Good for newcomers severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases labels Dec 12, 2024
@traeok traeok self-assigned this Dec 12, 2024
@traeok traeok moved this from New Issues to In Progress in Zowe Explorer for VS Code Dec 12, 2024
@traeok traeok added the severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases label Dec 12, 2024
@traeok traeok modified the milestone: v3.1.0 Dec 12, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Zowe Explorer for VS Code Dec 12, 2024
@traeok
Copy link
Member

traeok commented Dec 12, 2024

Keeping open until ported to v2

@traeok traeok reopened this Dec 12, 2024
@github-project-automation github-project-automation bot moved this from Closed to New Issues in Zowe Explorer for VS Code Dec 12, 2024
@traeok traeok moved this from New Issues to In Progress in Zowe Explorer for VS Code Dec 12, 2024
@traeok traeok moved this from In Progress to Review/QA in Zowe Explorer for VS Code Dec 12, 2024
@traeok traeok moved this from Review/QA to In Progress in Zowe Explorer for VS Code Dec 12, 2024
@traeok traeok closed this as completed Dec 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Zowe Explorer for VS Code Dec 16, 2024
@JillieBeanSim JillieBeanSim added this to the v3.1.0 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants