chore: first round of PR feedback

Signed-off-by: zFernand0 <[email protected]>

packages/zowe-explorer-api/src/extend/IRegisterClient.ts

@@ -118,7 +118,7 @@ export interface IRegisterClient {
     /**
      * Define events that fire whenever the credential manager is updated.
      */
-    onCredMgrsUpdate?: vscode.Event<Validation.EventType>;
+    onCredMgrUpdate?: vscode.Event<Validation.EventType>;
 
     /**
      * Lookup of any registered API (Uss, Mvs, Jes, or Command).

packages/zowe-explorer-ftp-extension/CHANGELOG.md

@@ -10,7 +10,6 @@ All notable changes to the "zowe-explorer-ftp-extension" extension will be docum
 
 - Changed the hashing algorithm for e-tag generation from `sha1` to `sha256` to avoid collisions. [#2890](https://github.com/zowe/zowe-explorer-vscode/pull/2890)
 - Updated the FTP plugin dependency to `3.0.0-next.202403191358` for technical currency [#2783](https://github.com/zowe/vscode-extension-for-zowe/pull/2783).
-- Update Zowe SDKs to `8.0.0-next.202405241828` for technical currency. [#2918](https://github.com/zowe/zowe-explorer-vscode/issues/2918)
 - Update Zowe SDKs to `8.0.0-next.202407232256` for technical currency. [#2994](https://github.com/zowe/zowe-explorer-vscode/pull/2994)
 
 ## `3.0.0-next.202404242037`

packages/zowe-explorer/CHANGELOG.md

@@ -42,8 +42,8 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen
 - Added error handling for when the default credential manager is unable to initialize. [#2811](https://github.com/zowe/zowe-explorer-vscode/issues/2811)
 - **Breaking:** Zowe Explorer no longer uses a temporary directory for storing Data Sets and USS files. All settings related to the temporary downloads folder have been removed. In order to access resources stored by Zowe Explorer v3, refer to the [FileSystemProvider documentation](https://github.com/zowe/zowe-explorer-vscode/wiki/FileSystemProvider) for information on how to build and access resource URIs. Extenders can detect changes to resources using the `onResourceChanged` function in the `ZoweExplorerApiRegister` class. [#2951](https://github.com/zowe/zowe-explorer-vscode/issues/2951)
 - Implemented the `onVaultUpdate` VSCode events to notify extenders when credentials are updated on the OS vault by other applications. [#2994](https://github.com/zowe/zowe-explorer-vscode/pull/2994)
-- Implemented the `onCredMgrsUpdate` VSCode events to notify extenders when the local PC's credential manager has been updated by other applications. [#2994](https://github.com/zowe/zowe-explorer-vscode/pull/2994)
 - Changed default base profile naming scheme in newly generated configuration files to prevent name and property conflicts between Global and Project profiles [#2682](https://github.com/zowe/zowe-explorer-vscode/issues/2682)
+- Implemented the `onCredMgrUpdate` VSCode events to notify extenders when the local PC's credential manager has been updated by other applications. [#2994](https://github.com/zowe/zowe-explorer-vscode/pull/2994)
 
 ### Bug fixes
 
@@ -63,7 +63,6 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen
 - Fixed issue where saving changes to favorited PDS member fails when custom temp folder is set on Windows. [#2880](https://github.com/zowe/zowe-explorer-vscode/issues/2880)
 - Fixed issue where multiple extensions that contribute profiles to a tree view using the Zowe Explorer API may fail to load. [#2888](https://github.com/zowe/zowe-explorer-vscode/issues/2888)
 - Fixed regression where `getProviderForNode` returned the wrong tree provider after performing an action on a Zowe tree node, causing some commands to fail silently. [#2967](https://github.com/zowe/zowe-explorer-vscode/issues/2967)
-- Update Zowe SDKs to `8.0.0-next.202407051717` for technical currency. [#2918](https://github.com/zowe/zowe-explorer-vscode/issues/2918)
 - Update Zowe SDKs to `8.0.0-next.202407232256` for technical currency. [#2994](https://github.com/zowe/zowe-explorer-vscode/pull/2994)
 
 ## `3.0.0-next.202404242037`

packages/zowe-explorer/__tests__/__mocks__/mockCreators/shared.ts

@@ -23,7 +23,7 @@ import { Definitions } from "../../../src/configuration/Definitions";
 
 const MOCK_PROFILES = [];
 
-export function createPersistentConfig(): any {
+export function createPersistentConfig(): Partial<Definitions.ZowePersistentFilter> & Partial<vscode.Memento> {
     return {
         persistence: true,
         get: (): Partial<Definitions.ZowePersistentFilter> => {
@@ -34,7 +34,7 @@ export function createPersistentConfig(): any {
         },
         update: jest.fn(() => {
             return {};
-        }),
+        }) as any,
     };
 }
 

packages/zowe-explorer/__tests__/__unit__/trees/dataset/DatasetActions.unit.test.ts

@@ -240,7 +240,7 @@ describe("Dataset Actions Unit Tests - Function createMember", () => {
             session: blockMocks.session,
         });
         const nonFavoriteLabel = parent.label;
-        parent.label = `${parent.label?.toString()}`;
+        parent.label = parent.label?.toString();
         parent.contextValue = Constants.DS_PDS_CONTEXT + Constants.FAV_SUFFIX;
 
         const mySpy = mocked(vscode.window.showInputBox).mockResolvedValue("testMember");

packages/zowe-explorer/__tests__/__unit__/trees/uss/UssFSProvider.unit.test.ts

@@ -279,7 +279,7 @@ describe("fetchEncodingForUri", () => {
         const lookupAsFileMock = jest.spyOn((UssFSProvider as any).prototype, "_lookupAsFile").mockReturnValueOnce(fileEntry);
         const autoDetectEncodingMock = jest.spyOn(UssFSProvider.instance, "autoDetectEncoding").mockImplementation((entry) => {
             entry.encoding = { kind: "text" };
-            return new Promise((resolve) => resolve());
+            return Promise.resolve();
         });
         await UssFSProvider.instance.fetchEncodingForUri(testUris.file);