Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding httpClientSessionInitv2 which through an argument will give the internal return code #499

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Gautham-coder
Copy link
Contributor

Problem

httpClientSessionInit has its own set of status values it returns, but the actual rc/rsn of commands it does within are hidden behind compile-time printf statements.
This is unhelpful because this function does fail sometimes, and on zOS the reason is opaque and requires a GSK trace to then discover the cause. It just costs extra debug time then.

Proposed changes

Here we have httpClientSessionInit to httpClientSessionInitv2 to allow passing back internal rc. The original api still exists and calls the new version by passing a dummy argument.

This PR addresses Issue: #468

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings

Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@JoeNemo JoeNemo merged commit 1e06b00 into v3.x/staging Nov 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants