-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(imperative): Enhanced ProfileInfo.updateProperty
#1983
Conversation
…o allow for `forceUpdate`s Signed-off-by: zFernand0 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1983 +/- ##
=======================================
Coverage 91.03% 91.03%
=======================================
Files 636 636
Lines 18713 18718 +5
Branches 3898 3900 +2
=======================================
+ Hits 17035 17040 +5
Misses 1677 1677
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good - just left a small request below 😋
Thanks @zFernand0!
Nice catch! Thank you, @traeok Co-authored-by: Trae Yelovich <[email protected]> Signed-off-by: Fernando Rijo Cedeno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for quickly addressing that @zFernand0 😁 LGTM
Signed-off-by: zFernand0 <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
forceUpdate
optional property to theProfileInfo.updateProperty
method.How to Test
Check out the GIF at the bottom 😋
OR
forceUpdate: false
: thebase
profile is updatedforceUpdate: true
: theapiml
profile is updatedUse this config file for testing purposes
Use this little
test.mjs
script for testing purposesReview Checklist
I certify that I have:
Additional Comments
This is intended to help with the implementation of: