Add checking the uss file path when upload file or stdin to uss file. #145
Conversation
Signed-off-by: Tian Na <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 72.39% 73.04% +0.64%
==========================================
Files 79 80 +1
Lines 960 983 +23
Branches 125 130 +5
==========================================
+ Hits 695 718 +23
Misses 244 244
Partials 21 21 ☔ View full report in Codecov by Sentry. |
| params.response.data.setMessage(successMsg); | ||
| this.log.info(successMsg); | ||
|
|
||
| if (!ussFile.startsWith('/')) { |
There was a problem hiding this comment.
Good to have this check in UssUtils.checkAbsoluteFilePath(filePath), which returns error message when the check fails. In this way, we can avoid having the check and error message duplicate in two places.
There was a problem hiding this comment.
Thank you @std4lqi ! I add checkAbsoluteFilePath in UssUtils and add test in UssUtils.test.ts.
Signed-off-by: Tian Na <[email protected]>
Signed-off-by: Tian Na <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks, @tiantn ! |
| if (!filePath.startsWith('/')) { | ||
| throw new ImperativeError({ msg: "Please check the uss file path. The full file path is required."}); | ||
| } else { | ||
| return filePath; |
There was a problem hiding this comment.
Based on the current usage of the function, I don't think we need to return the filePath, but it doesn't hurt (in case we want to use it in the near future)
No changes requested here 😋
zFernand0
added
the
release-patch
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
How to Test
Review Checklist
I certify that I have:
Additional Comments
fix #144