add checking files length as well and update unit test

Signed-off-by: Tian Na <[email protected]>
zowe · Jun 4, 2024 · 7827720 · 7827720
1 parent a2fcbc7
commit 7827720
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 19 deletions.
diff --git a/__tests__/__unit__/cli/list/spool-files-by-jobid/SpoolFilesByJobid.Handler.test.ts b/__tests__/__unit__/cli/list/spool-files-by-jobid/SpoolFilesByJobid.Handler.test.ts
@@ -14,6 +14,7 @@ import TestUtils from "../../TestUtils";
 
 describe("List spool files by job id handler", () => {
 
+    // eslint-disable-next-line jest/no-focused-tests
     it("should return no spool file if the no spool file is not found.", async () => {
         const handler = new ListSpoolFilesByJobidHandler();
         const files: any[] = [];
@@ -34,9 +35,7 @@ describe("List spool files by job id handler", () => {
             response: mockResponse
         };
         await handler.processFTP(mockParams);
-        expect(mockResponse.data.setMessage.mock.calls[0][0]).toBe("\"0\" spool files obtained for job \"jobName1(jobId1)\"");
-        expect(mockResponse.data.setObj.mock.calls[0][0]).toMatchSnapshot();
-        expect(mockResponse.format.output.mock.calls[0][0]).toMatchSnapshot();
+        expect(mockResponse.console.log.mock.calls[0]).toContain("No spool file.");
     });
 
     it("should return correct message if at least one spool file is found.", async () => {

diff --git a/...unit__/cli/list/spool-files-by-jobid/__snapshots__/SpoolFilesByJobid.Handler.test.ts.snap b/...unit__/cli/list/spool-files-by-jobid/__snapshots__/SpoolFilesByJobid.Handler.test.ts.snap
@@ -50,18 +50,3 @@ Object {
   ],
 }
 `;
-
-exports[`List spool files by job id handler should return no spool file if the no spool file is not found. 1`] = `Array []`;
-
-exports[`List spool files by job id handler should return no spool file if the no spool file is not found. 2`] = `
-Object {
-  "fields": Array [
-    "id",
-    "ddName",
-    "procStep",
-    "stepName",
-  ],
-  "format": "table",
-  "output": Array [],
-}
-`;
diff --git a/src/cli/list/spool-files-by-jobid/SpoolFilesByJobid.Handler.ts b/src/cli/list/spool-files-by-jobid/SpoolFilesByJobid.Handler.ts
@@ -23,7 +23,7 @@ export default class ListSpoolFilesByJobidHandler extends FTPBaseHandler {
         this.log.debug("Listing spool files for job ID %s", params.arguments.jobId);
         const job = await JobUtils.findJobByID(params.connection, params.arguments.jobId);
         const files = job.spoolFiles;
-        if (files) {
+        if (files?.length > 0) {
             const successMessage = this.log.info(`"${files.length}" spool files obtained for job "${job.jobName}(${job.jobId})"`);
             // Set the object, message, and log the prettified object
             params.response.data.setObj(files);