Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK getResource failOnNoData flag #205

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

AndrewTwydell
Copy link
Contributor

What It Does
Adds a failOnNodata flag, defaulting to true (which is the current behaviour), to dictate if CMCI sending a NODATA response should throw an error or not.

Review Checklist
I certify that I have:

Additional Comments

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.42%. Comparing base (63501a8) to head (ec5b1e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   28.37%   28.42%   +0.05%     
==========================================
  Files         148      148              
  Lines        5082     5083       +1     
  Branches      892      892              
==========================================
+ Hits         1442     1445       +3     
+ Misses       3640     3638       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants