Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch NODATA response when generating cache #201

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

AndrewTwydell
Copy link
Contributor

What It Does
Resolves #200

Adds a check for a NODATA response when generating a cache token for the combined trees. If the query comes back with NODATA, an error is thrown by the SDK. This was not handled and ignored by the VSCE.

Review Checklist
I certify that I have:

Screenshot 2025-01-09 at 10 59 38 PM

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.47%. Comparing base (22639c6) to head (76e8e3c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
packages/vsce/src/utils/profileManagement.ts 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   28.46%   28.47%   +0.01%     
==========================================
  Files         148      148              
  Lines        4954     4958       +4     
  Branches      859      797      -62     
==========================================
+ Hits         1410     1412       +2     
- Misses       3544     3546       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davenice davenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got distracted while looking at this.

It looks good to me. Simpler than our late night marathon last week because most of the logic is similar, we just need to catch the error! And we've already got code to return a blank.

Signed-off-by: Andrew <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

packages/vsce/src/utils/profileManagement.ts Show resolved Hide resolved
@zFernand0 zFernand0 merged commit eda5d41 into main Jan 15, 2025
18 checks passed
@zFernand0 zFernand0 deleted the catch-nodata-cache branch January 15, 2025 22:10
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Jan 15, 2025
Copy link

Release succeeded for the main branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Filtering All Resources trees errors if none are found
4 participants