-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch NODATA response when generating cache #201
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
+ Coverage 28.46% 28.47% +0.01%
==========================================
Files 148 148
Lines 4954 4958 +4
Branches 859 797 -62
==========================================
+ Hits 1410 1412 +2
- Misses 3544 3546 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrew Twydell <[email protected]>
8d57393
to
cd6ff20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got distracted while looking at this.
It looks good to me. Simpler than our late night marathon last week because most of the logic is similar, we just need to catch the error! And we've already got code to return a blank.
Signed-off-by: Andrew <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Resolves #200
Adds a check for a NODATA response when generating a cache token for the combined trees. If the query comes back with NODATA, an error is thrown by the SDK. This was not handled and ignored by the VSCE.
Review Checklist
I certify that I have: