Now URI encoding the region and cicsplex names

[enamkhan]

What It Does
Issues was caused by not encoding the # so have updated the getResourceUri method so that both the region and cicsplex names are now uri encoded.

How to Test
Created a region with a # in the name and connected with updated extension. Have also added some unit tests to cover this case.

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments
Resolves #178

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (65c19a2) to head (c18d6b6).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files          75       75           
  Lines         770      770           
  Branches       43       42    -1     
=======================================
  Hits          722      722           
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davenice]

Thanks Enam - one thing worth mentioning is that I have seen a customer using system groups with hashes in - system groups don't support wildcards so they made their own which they maintained manually 😬

I don't think there is a lot of support for system groups in the GUI - the main one I've seen is that if you specify a region in your config, you can specify a system group instead. I think this will work with your changes because I think the code just sees it as a region name rather than a region group - do you think we've covered all the places this might need addressing?

[AndrewTwydell]

Looks great - few things to look at 😄

[AndrewTwydell]

LGTM 👍🏼

[zFernand0]

Overall, this LGTM! 😋

I do have one small request to keep the old CMCI.constant to avoid possible breaking changes 🙏

[zFernand0]

LGTM! 😋

[github-actions]

Release succeeded for the main branch. 🎉

The following packages have been published:

• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• vsce: [email protected]
• vsce: [email protected] (OVSX)

_{Powered by Octorelease 🚀}