Change criteria bracketing behaviour #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Twydell <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 93.81% 93.76% -0.05%
==========================================
Files 75 75
Lines 776 770 -6
Branches 44 42 -2
==========================================
- Hits 728 722 -6
Misses 48 48 ☔ View full report in Codecov by Sentry. |
|
I've tested this by pulling the head commit from main, running I then pull the bracketing branch, I've tried (successfully)...
|
Joe-Winchester
approved these changes
Dec 19, 2024
AndrewTwydell
added
the
release-patch
github-actions
bot
removed
the
release-patch
AndrewTwydell
added
the
release-patch
github-actions
bot
removed
the
release-patch
zFernand0
added
the
release-patch
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
zFernand0
reviewed
Dec 19, 2024
| @@ -398,12 +398,12 @@ describe('Utils - enforceParentheses', () => { | |||
|
|
|||
| it("should add first bracket when end exists", () => { | |||
| const output = Utils.enforceParentheses("input with spaces)"); | |||
| expect(output).toEqual("(input with spaces)"); | |||
| expect(output).toEqual("(input with spaces))"); | |||
There was a problem hiding this comment.
I haven't tested this yet, but it doesn't seem like having an extra closing ) will work in some scenarios 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Resolves #180
Adds vagueness to the bracketing behaviour to allow a string that ends in brackets but not starts with to be handled correctly. This does add some responsibility to the caller creating the criteria string, but prevents unwanted behaviour like the below example.
Currently, if you pass a string like
NOT (PROGRAM=ABC* OR PROGRAM=BCD*), it will send back(NOT (PROGRAM=ABC* OR PROGRAM=BCD*), whereas we would want a bracket at the end too.Review Checklist
I certify that I have: