-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCE: Renamed to IBM CICS for Zowe Explorer #135
Conversation
fix #129 Signed-off-by: zFernand0 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=======================================
Coverage 93.28% 93.28%
=======================================
Files 74 74
Lines 760 760
Branches 94 93 -1
=======================================
Hits 709 709
Misses 51 51 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the name here too? We may be able to make it dynamic with context.extension.name
or something similar rather than being hardcoded.
logger.error("Zowe Explorer for IBM CICS was not initiliaized correctly"); |
Signed-off-by: zFernand0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks @zFernand0 for the renaming!
Signed-off-by: zFernand0 <[email protected]>
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Renames the extension to
IBM CICS for Zowe Explorer
Review Checklist
I certify that I have: