-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #28 from zowe/fix-secrets
Fix: secrets SDK usage
- Loading branch information
Showing
42 changed files
with
8,020 additions
and
5,098 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,15 @@ | ||
| ## Proposed changes | ||
| **What It Does** | ||
| <!-- A list of relevant issues, enhancements, fixed bugs, etc --> | ||
|
|
||
| <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. --> | ||
| **How to Test** | ||
| <!-- If a bug has been fixed, how can reviewers verify that the change(s) fixed it? --> | ||
|
|
||
| ## Release Notes | ||
| **Review Checklist** | ||
| I certify that I have: | ||
| - [ ] tested my changes | ||
| - [ ] added/updated automated tests | ||
| - [ ] updated the changelog | ||
| - [ ] followed the [contribution guidelines](https://github.com/zowe/zowe-cli/blob/master/CONTRIBUTING.md) | ||
|
|
||
| Milestone: | ||
| <!-- Include the Milestone Number and a small description of your change that will be added to the changelog --> | ||
| <!-- If there is a linked issue, it should have the same milestone as this PR --> | ||
|
|
||
| Changelog: | ||
|
|
||
| ## Types of changes | ||
|
|
||
| What types of changes does your code introduce to Zowe CICS Explorer? | ||
| _Put an `x` in the boxes that apply_ | ||
|
|
||
| - [ ] Bugfix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
| - [ ] Updates to Documentation or Tests (if none of the other choices apply) | ||
|
|
||
| ## Checklist | ||
|
|
||
| _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer_ | ||
|
|
||
| - [ ] PR Description is included | ||
| - [ ] gif or screenshot is included if visual changes are made | ||
| - [ ] All checks have passed (DCO, Jenkins and Code Coverage) | ||
| - [ ] I have added unit test and it is passing | ||
| - [ ] There is coverage for the code that I have added | ||
| - [ ] I have tested it manually and there are no regressions found | ||
| - [ ] I have added necessary documentation (if appropriate) | ||
| - [ ] Any PR dependencies have been merged and published (if appropriate) | ||
|
|
||
| ## Further comments | ||
|
|
||
| <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> | ||
| **Additional Comments** | ||
| <!-- Anything else noteworthy about this pull request. This section is optional. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ name: Zowe CICS Main CI | |
| on: | ||
| push: | ||
| paths: | ||
| - .github/** | ||
| - packages/** | ||
| pull_request: | ||
| paths: | ||
|
|
@@ -19,7 +20,7 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [16.x, 18.x] | ||
| node-version: [16.x, 18.x, 20.x] | ||
| os: [windows-latest, ubuntu-latest, macos-latest] | ||
|
|
||
| env: | ||
|
|
@@ -35,10 +36,10 @@ jobs: | |
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v3 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
|
|
||
|
|
@@ -50,6 +51,13 @@ jobs: | |
| - name: Install Dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Update Dependencies | ||
| id: npm-update | ||
| uses: zowe-actions/octorelease/script@v1 | ||
| with: | ||
| config-dir: .github | ||
| script: npmUpdate | ||
|
|
||
| - name: Build Source | ||
| id: build | ||
| run: npm run build | ||
|
|
@@ -60,23 +68,69 @@ jobs: | |
|
|
||
| - name: Archive Results | ||
| if: ${{ always() && steps.build.outcome == 'success' }} | ||
| uses: actions/upload-artifact@v3 | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ matrix.os }}-${{ matrix.node-version }}-results | ||
| path: packages/*/__tests__/__results__/ | ||
|
|
||
| - name: Upload Results to Codecov | ||
| uses: codecov/codecov-action@v3 | ||
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| env_vars: OS,NODE | ||
|
|
||
| - name: Bundle all packages | ||
| if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18.x' | ||
| run: npm i -g vsce && npm run package | ||
| # - name: Bundle all packages | ||
| # if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18.x' | ||
| # run: npm i -g vsce && npm run package | ||
|
|
||
| # - name: Archive all packages | ||
| # if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18.x' | ||
| # uses: actions/upload-artifact@v4 | ||
| # with: | ||
| # name: zowe-cics-client | ||
| # path: dist/* | ||
|
|
||
| release: | ||
| if: github.event_name == 'push' && github.ref_protected | ||
| needs: test | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| ref: ${{ github.ref }} | ||
|
|
||
| - name: Use Node.js LTS | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: lts/* | ||
|
|
||
| - name: Install Dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Update Dependencies | ||
| uses: zowe-actions/octorelease/script@v1 | ||
| env: | ||
| GIT_COMMITTER_NAME: zowe_robot | ||
| GIT_COMMITTER_EMAIL: [email protected] | ||
| NPM_RESOLUTIONS: ${{ needs.test.outputs.npm-resolutions }} | ||
| with: | ||
| config-dir: .github | ||
| script: npmUpdate | ||
|
|
||
| - name: Build Source | ||
| run: npm run build | ||
|
|
||
| - name: Archive all packages | ||
| if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18.x' | ||
| uses: actions/upload-artifact@v3 | ||
| - uses: zowe-actions/octorelease@fix/allow-first-time-publish2 | ||
| env: | ||
| GIT_COMMITTER_NAME: ${{ secrets.ZOWE_ROBOT_USER }} | ||
| GIT_COMMITTER_EMAIL: ${{ secrets.ZOWE_ROBOT_EMAIL }} | ||
| GIT_CREDENTIALS: x-access-token:${{ secrets.ZOWE_ROBOT_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NPM_USERNAME: ${{ secrets.ARTIFACTORY_USERNAME }} | ||
| NPM_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }} | ||
| NPM_EMAIL: ${{ secrets.ZOWE_ROBOT_EMAIL }} | ||
| with: | ||
| name: zowe-cics-client | ||
| path: dist/* | ||
| config-dir: .github | ||
Oops, something went wrong.