Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to add DENY ACEs. #41

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Added ability to add DENY ACEs. #41

merged 1 commit into from
Dec 22, 2021

Conversation

zorn96
Copy link
Owner

@zorn96 zorn96 commented Dec 22, 2021

Updating security descriptor utils with functions for creating DENY ACEs
for both general access masks as well as specific rights GUIDs.
Additionally updated the ADSession functions for adding permissions to
allow those permissions to be "DENY" ACEs, since adding a DENY ACE is
different from removing a permission.

Updated docs.

@zorn96
Copy link
Owner Author

zorn96 commented Dec 22, 2021

this relates to improved support for #39 (though I intend to add a protect_from_accidental_deletion kwarg to user/group/computer creation in the future, as that seems useful and is a pretty normal use case.

@isaiahh1013 fyi - this will be in dev if you want to try it out. I'm still testing it, since DENY ACEs are weird and I need to be sure this behaves properly in all scenarios. but once I finish testing it, I'll release a new version and also look at adding the protect_from_accidental_deletion kwarg

Updating security descriptor utils with functions for creating DENY ACEs
for both general access masks as well as specific rights GUIDs.
Additionally updated the ADSession functions for adding permissions to
allow those permissions to be "DENY" ACEs, since adding a DENY ACE is
different from removing a permission.

Updated docs.
@zorn96 zorn96 merged commit 5f0cf68 into dev Dec 22, 2021
@zorn96 zorn96 deleted the deny-ace-support branch December 22, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant