-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure with meta/config. #243
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b71d1bd
Configure with meta/config.
183bd2d
Fix change log and hopefully fix tests.
bf839cf
Configuring for c-code
22926c4
We need `Sphinx < 4` + remove left-overs of coverage_python_version.
e8ad4a1
Pin Sphinx for GHA, too.
ce49b27
Install in proper order.
2298be3
Improve coverage.
c6cba84
Improve coverage a bit more.
88177f4
Adapt coverage.
256c406
Fix usage of setenv.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,29 @@ | ||
# Generated from: | ||
# https://github.com/zopefoundation/meta/tree/master/config/c-code | ||
[run] | ||
branch = True | ||
source = zope.interface | ||
# New in 5.0; required for the GHA coveralls submission. | ||
relative_files = True | ||
branch = true | ||
|
||
[paths] | ||
source = | ||
src/ | ||
.tox/*/lib/python*/site-packages/ | ||
.tox/pypy*/site-packages/ | ||
|
||
[report] | ||
show_missing = true | ||
precision = 2 | ||
exclude_lines = | ||
except ImportError: | ||
if __name__ == '__main__': | ||
pragma: no cover | ||
class I[A-Z]\w+\((Interface|I[A-Z].*)\): | ||
raise NotImplementedError | ||
pragma: nocover | ||
raise AssertionError | ||
self\.fail | ||
raise NotImplementedError | ||
raise unittest.Skip | ||
self.fail\( | ||
|
||
[html] | ||
directory = parts/htmlcov |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# Generated from: | ||
# https://github.com/zopefoundation/meta/tree/master/config/c-code | ||
# | ||
# EditorConfig Configuration file, for more details see: | ||
# http://EditorConfig.org | ||
# EditorConfig is a convention description, that could be interpreted | ||
# by multiple editors to enforce common coding conventions for specific | ||
# file types | ||
|
||
# top-most EditorConfig file: | ||
# Will ignore other EditorConfig files in Home directory or upper tree level. | ||
root = true | ||
|
||
|
||
[*] # For All Files | ||
# Unix-style newlines with a newline ending every file | ||
end_of_line = lf | ||
insert_final_newline = true | ||
trim_trailing_whitespace = true | ||
# Set default charset | ||
charset = utf-8 | ||
# Indent style default | ||
indent_style = space | ||
# Max Line Length - a hard line wrap, should be disabled | ||
max_line_length = off | ||
|
||
[*.{py,cfg,ini}] | ||
# 4 space indentation | ||
indent_size = 4 | ||
|
||
[*.{yml,zpt,pt,dtml}] | ||
# 2 space indentation | ||
indent_size = 2 | ||
|
||
[{Makefile,.gitmodules}] | ||
# Tab indentation (no size specified, but view as 4 spaces) | ||
indent_style = tab | ||
indent_size = unset | ||
tab_width = unset |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,29 @@ | ||
*.egg-info | ||
# Generated from: | ||
# https://github.com/zopefoundation/meta/tree/master/config/c-code | ||
*.egg-info/ | ||
*.profraw | ||
*.pyc | ||
*.pyo | ||
*.so | ||
*.swp | ||
__pycache__ | ||
.coverage | ||
.coverage.* | ||
.installed.cfg | ||
default.profraw | ||
nosetests.xml | ||
coverage.xml | ||
pyvenv.cfg | ||
.eggs/ | ||
.installed.cfg | ||
.mr.developer.cfg | ||
.tox/ | ||
.vscode/ | ||
__pycache__/ | ||
bin/ | ||
build/ | ||
eggs/ | ||
coverage.xml | ||
develop-eggs/ | ||
docs/_build/ | ||
develop/ | ||
dist/ | ||
docs/_build | ||
eggs/ | ||
etc/ | ||
lib/ | ||
lib64 | ||
log/ | ||
parts/ | ||
htmlcov/ | ||
pyvenv.cfg | ||
var/ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much coverage are we losing by dropping this from exclude_lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hopefully fixed all the places where this line ignored methods by changing
pass
to a docstring.There is still https://coveralls.io/builds/39516428/source?filename=src%2Fzope%2Finterface%2Fcommon%2Fcollections.py#L221 which I do not understand as I thought we have coverage for all Python versions. (There are some other cases which look the same.)