Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DNSSEC10 implementation #1396

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Update DNSSEC10 implementation #1396

merged 4 commits into from
Nov 27, 2024

Conversation

tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Nov 12, 2024 •
edited
Loading

Purpose

This PR proposes an update to the implementation of DNSSEC10 following a specification update.

Context

Test case specification update: zonemaster/zonemaster#1179
Test zone specification: zonemaster/zonemaster#1294

Fixes #1016, #1253

How to test this PR

Unit tests are updated (based on zonemaster/zonemaster#1294) and should pass.

@tgreenx tgreenx added A-TestCase Area: Test case specification or implementation of test case FA-MethodV2 Focus Area: Implementing and migrating to MethodNT for test cases. labels Nov 12, 2024
@tgreenx tgreenx added this to the v2024.2 milestone Nov 12, 2024
@tgreenx tgreenx mentioned this pull request Nov 13, 2024
Merged
@matsduf matsduf added the V-Minor Versioning: The change gives an update of minor in version. label Nov 13, 2024
@tgreenx tgreenx force-pushed the update-dnssec10 branch 3 times, most recently from d4ee05b to 2a83a5d Compare November 19, 2024 17:17
@tgreenx tgreenx mentioned this pull request Nov 19, 2024
Merged
48 tasks
This was linked to issues Nov 19, 2024
Error in dnssec10-non-existent-domain-name-exists-03.zft-root.rd.nic.fr #1016
Open
False error in DNSSEC10 on a zone with a wildcard below apex #1253
Closed
@tgreenx tgreenx mentioned this pull request Nov 20, 2024
Merged
@tgreenx tgreenx marked this pull request as ready for review November 26, 2024 09:23
@tgreenx
Copy link
Contributor Author

tgreenx commented Nov 26, 2024

@matsduf @mattias-p @tolvmannen @marc-vanderwal @MichaelTimbert This PR is now ready for review.

MichaelTimbert
MichaelTimbert previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@MichaelTimbert MichaelTimbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working for me.

@matsduf
Copy link
Contributor

matsduf commented Nov 26, 2024

https://github.com/zonemaster/zonemaster-engine/pull/1396/files#diff-3c6ad87ddb974fb813839bacdaafd4e212c238d0ff6865a9bf6cf677403343deR452-R469 does not seem to be updated:

        dnssec10 => [
            qw(                                                                                                                             
              DS10_ALGO_NOT_SUPPORTED_BY_ZM                                                                                                 
              DS10_ANSWER_VERIFY_ERROR                                                                                                      
              DS10_HAS_NSEC                                                                                                                 
              DS10_HAS_NSEC3                                                                                                                
              DS10_INCONSISTENT_NSEC_NSEC3                                                                                                  
              DS10_MISSING_NSEC_NSEC3                                                                                                       
              DS10_MIXED_NSEC_NSEC3                                                                                                         
              DS10_NAME_NOT_COVERED_BY_NSEC                                                                                                 
              DS10_NAME_NOT_COVERED_BY_NSEC3                                                                                                
              DS10_NON_EXISTENT_RESPONSE_ERROR                                                                                              
              DS10_NSEC3_MISSING_SIGNATURE                                                                                                  
              DS10_NSEC3_RRSIG_VERIFY_ERROR                                                                                                 
              DS10_NSEC_MISSING_SIGNATURE                                                                                                   
              DS10_NSEC_RRSIG_VERIFY_ERROR                                                                                                  
              DS10_UNSIGNED_ANSWER                                                                                                          
              )
        ],

@tgreenx
Copy link
Contributor Author

tgreenx commented Nov 26, 2024

https://github.com/zonemaster/zonemaster-engine/pull/1396/files#diff-3c6ad87ddb974fb813839bacdaafd4e212c238d0ff6865a9bf6cf677403343deR452-R469 does not seem to be updated:

Indeed, forgot this part, updated now in 6fa9921.

@tgreenx tgreenx merged commit d512d53 into zonemaster:develop Nov 27, 2024
3 checks passed
@tgreenx tgreenx deleted the update-dnssec10 branch November 27, 2024 13:01
@MichaelTimbert MichaelTimbert added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Dec 3, 2024
@tgreenx tgreenx mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsduf matsduf matsduf approved these changes

@mattias-p mattias-p Awaiting requested review from mattias-p

@tolvmannen tolvmannen Awaiting requested review from tolvmannen

@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal

@MichaelTimbert MichaelTimbert Awaiting requested review from MichaelTimbert

Assignees
No one assigned
Labels
A-TestCase Area: Test case specification or implementation of test case FA-MethodV2 Focus Area: Implementing and migrating to MethodNT for test cases. S-ReleaseTested Status: The PR has been successfully tested in release testing V-Minor Versioning: The change gives an update of minor in version.
Projects
None yet
Milestone
v2024.2
3 participants
@tgreenx @matsduf @MichaelTimbert