New unit tests for Delegation01, -02 and -03, and legacy tests are removed

[matsduf]

Purpose

This PR implements the scenarios and test zones for Delegation01, Delegation02 and Delegation03 defined in zonemaster/zonemaster#1305.

This PR is built on top of commit b276cf8 in PR #1393 to get updated version of t/TestUtil.pm.

Old legacy unit tests files are removed. The zones behind most of them will soon be removed.

In unit test file t/Test-delegation.t legacy tests and commented code have been removed. The file, however, cannot be rerecorded due to changes in zones not controlled by Zonemaster.

Some scenarios for Delegation01 cannot be included due to bug or bugs in the implementation (not in the scope of this PR):

t/Test-delegation01.t .. 1/? Untested scenarios:
	Scenario ENOUGH-DEL-NOT-CHILD cannot be tested.
	Scenario IPV4-AND-DEL-OK-NO-IPV6-CHILD cannot be tested.
	Scenario IPV6-AND-DEL-OK-NO-IPV4-CHILD cannot be tested.
	Scenario MISMATCH-DELEGATION-CHILD-1 cannot be tested.
	Scenario MISMATCH-DELEGATION-CHILD-2 cannot be tested.

Some scenarios for Delegation02 cannot be included due to bug or bugs in the implementation (not in scope of this PR):

t/Test-delegation02.t .. 1/? Untested scenarios:
	Scenario CHILD-NON-DISTINCT cannot be tested.
	Scenario DEL-NON-DISTINCT cannot be tested.

Please note that scenario CHILD-NON-DISTINCT and CHILD-NON-DISTINCT-UND are the same except for that the latter is undelegated. And the latter passes. The same for DEL-NON-DISTINCT and DEL-NON-DISTINCT-UND. This shows that the code does not handle normal and undelegated tests in the sama way. The zone content "poisons" the delegation.

No issues with Delegation03.

Context

zonemaster/zonemaster#1305.

This PR is built on top of #1398. Commit e9060d1 does not belong to this PR.

Changes

...

How to test this PR

• The tests should pass.
• Review Creates test scenarios and test zones for test cases Delegation01, -02 and -03 zonemaster#1305.

[matsduf]

@mattias-p, @marc-vanderwal, @tolvmannen, @tgreenx -- please review.

[marc-vanderwal]

Looks fine. Just some really minor nits.

[matsduf]

@marc-vanderwal, please re-review.

The merge-base changed after approval.

The merge-base changed after approval.

[matsduf]

@marc-vanderwal, I do not know what "The merge-base changed after approval" really means. I did not do anything.

[marc-vanderwal]

Isn’t it because PRs are being merged in the develop branch and that this PR is being rebased continuously on the latest develop? I’m not sure either. Weird.

The merge-base changed after approval.

[matsduf]

Isn’t it because PRs are being merged in the develop branch and that this PR is being rebased continuously on the latest develop? I’m not sure either. Weird.

It has only been rebased once, and that was on top of ommit e9060d1. I have never seen this behavior before.

The merge-base changed after approval.

[tgreenx]

Isn’t it because PRs are being merged in the develop branch and that this PR is being rebased continuously on the latest develop? I’m not sure either. Weird.

It has only been rebased once, and that was on top of ommit e9060d1. I have never seen this behavior before.

Looks like a known bug in Github: https://github.com/orgs/community/discussions/58535?sort=top

Re-selecting the base branch seems to make it go away.

[matsduf]

After the approval by @marc-vanderwal there as been no change, just execution of the Github bug.