Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(game): add priority and blur to images #86

Merged
merged 1 commit into from
Oct 25, 2023
Merged

perf(game): add priority and blur to images #86

merged 1 commit into from
Oct 25, 2023

Conversation

jsun969
Copy link
Contributor

@jsun969 jsun969 commented Oct 25, 2023

No description provided.

@jsun969 jsun969 requested a review from CaliCastle October 25, 2023 06:46
@linear
Copy link

linear bot commented Oct 25, 2023

LB-104 Preload Images

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
isthat-ai ✅ Ready (Inspect) Visit Preview Oct 25, 2023 6:48am

@@ -43,6 +50,7 @@ function Handler({
width={64}
height={64}
onClick={() => onClick(step + 1)}
priority
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的图片好像是动态的,priority 能生效吗

@@ -34,6 +40,7 @@ function Handler({
alt="prev"
width={104}
height={24}
priority
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有这里

Copy link
Contributor

@CaliCastle CaliCastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有点过度优化了。。
当 Image 大部份都是 priority 的时候,priority 不再是 priority

@jsun969 jsun969 merged commit 34d10b9 into dev Oct 25, 2023
1 check passed
@jsun969 jsun969 deleted the justin/lb-104 branch October 25, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants