-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remove unused values from default request params
Recently, the Fitbit API appears to throw bad request errors if passing empty params to some of its endpoints - in particular it would error out on the activity logs list endpoint as both the beforeDate and afterDate params are being sent over, even though the afterDate param is null by default. Previously, it looks like Fitbit's API would gracefully handle these nil params but in this case it explicitly fails as you can't have both a before and after date set at the same time. This updates affected methods so that unused values are removed from the default params object. There should be no difference in behavior other than fixing the recently broken activity logs endpoint.
- Loading branch information
Showing
3 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters