Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static linking with latest ffmpeg fails with link errors #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msabansal
Copy link

Static linking with latest ffmpeg gives the following error:

   avdevice.lib(dshow.o) : error LNK2001: unresolved external symbol IID_IBaseFilter
   avdevice.lib(dshow_filter.o) : error LNK2001: unresolved external symbol IID_IBaseFilter
   
   <snip>
   
   fatal error LNK1120: 32 unresolved externals

Adding the missing libraries to fix it.

Static linking with latest ffmpeg gives the following error: 
  avdevice.lib(dshow.o) : error LNK2001: unresolved external symbol IID_IBaseFilter
          avdevice.lib(dshow_filter.o) : error LNK2001: unresolved external symbol IID_IBaseFilter
 <snip>          
 fatal error LNK1120: 32 unresolved externals

Adding the missing libraries to fix it
@dmtrKovalenko
Copy link
Collaborator

which feature flags are you building it for:?

@msabansal
Copy link
Author

I installed ffmpeg static build for x264 using the following command:

vcpkg install ffmpeg[x264] --triplet x64-windows-static-md

Running the build after this with the static feature flag fails with the above error.

@dmtrKovalenko
Copy link
Collaborator

Can we do this only for windows?

@msabansal
Copy link
Author

Is the current change compiled on other platform aswell? Seeing user32 and bcrypt i assumed this branch was windows only

@dmtrKovalenko
Copy link
Collaborator

Probably you are right, but this a vcpkg branch which is available on any platform. Not sure how it works in other platforms but I would prefer to not try linking windows libraries at all. Could you add a guard for all of them?

@msabansal
Copy link
Author

The try_vcpkg method return None on non msvc environments so looks to be only building on windows here. Would prefer to avoid any additional conditionals.
Thanks for the quick review BTW 👍

@dmtrKovalenko
Copy link
Collaborator

great

@msabansal
Copy link
Author

checking if this can be retriggered for a merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants