feat: Hardware accelleration build options #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds 2 well-tested by my hardware accelleration platforms: Native apple video- & audiotoolbox and Nvidia CUDA. nvidia cuda is a little bit weird cause it always require at least 3 flags to be build and there is no reason to separate them so I decided to have one feature flag at least here instead
dmtrKovalenko
force-pushed
the
feat/hardware-accelleration
branch
from
32bc5c7 to
776df8b
Compare
russelltg
reviewed
Nov 5, 2024
| // hardware accelleration | ||
| enable!(configure, "BUILD_VAAPI", "vaapi"); | ||
| enable!(configure, "BUILD_VULKAN", "vdpau"); | ||
| enable!(configure, "BUILD_OPENCL", "vaapi"); |
There was a problem hiding this comment.
Yeah thanks, I should’ve made it as a draft cause I’m still experimenting with options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 well-tested by my hardware accelleration platforms: Native apple video- & audiotoolbox and Nvidia CUDA.
nvidia cuda is a little bit weird cause it always require at least 3 flags to be build and there is no reason to separate them so I decided to have one feature flag at least here instead