Feat/start regular upgrades #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker fullstack almost working
…start-regular-upgrades
Send to transactions page on broadcast. Toast
aon
reviewed
Sep 25, 2024
apps/web/app/.server/service/ethereum-l2/contracts/governors.ts
Outdated
Show resolved
Hide resolved
apps/web/app/.server/service/ethereum-l2/contracts/governors.ts
Outdated
Show resolved
Hide resolved
apps/web/app/.server/service/ethereum-l2/contracts/governors.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+10
to
+25
| export const upgradeStructAbi = { | ||
| type: "tuple", | ||
| components: [ | ||
| { | ||
| type: "tuple[]", | ||
| components: [ | ||
| { type: "address", name: "target" }, | ||
| { type: "uint256", name: "value" }, | ||
| { type: "bytes", name: "data" }, | ||
| ], | ||
| name: "calls", | ||
| }, | ||
| { type: "address", name: "executor" }, | ||
| { type: "bytes32", name: "salt" }, | ||
| ], | ||
| } as const; |
There was a problem hiding this comment.
Can we get this from the abis in packages/contracts?
There was a problem hiding this comment.
Maybe we can!
There was a problem hiding this comment.
I didn't find a clean way to extrasct an struct from the abi. Maybe we can do something else, though. I'm not sure.
Co-authored-by: Agustin Aon <[email protected]>
Co-authored-by: Agustin Aon <[email protected]>
aon
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start regular upgrades.