Dev mode for zkopru client package #40
Conversation
README.md
Outdated
|
|
||
| ## Development alongside @zkopru/client | ||
|
|
||
| the web wallet download `@zkopru/client` module from npm while installing. for more convenience to develop alongside @zkopru/client, It would be better to use a client package that is locally cloned. |
There was a problem hiding this comment.
question about this, it works well by using yarn link @zkopru/client as mentioned above Line16. Why do we need to have another command npm run install-dev for zkopru/client integration?
There was a problem hiding this comment.
In my environment, yarn link requires permission to create a folder in the global node module.
I think it is okay setup and forgets in this way. If you use yarn link, have to unlink at some point, even though not worry about the permission.
There was a problem hiding this comment.
May need some more explanation in this section about using the script or yarn link :)
| WEBSOCKET: 'wss://optimism-kovan.zkopru.network', | ||
| } | ||
|
|
||
| if (process.env.NODE_ENV == "development") { |
There was a problem hiding this comment.
Why not keep the config for testnet? If we changed to this, we can only support local dev env only.
This PR for solving the issue zkopru-network/zkopru#410