veredise audit fix: Unused program constructs #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtial_sha256_var_start then remaining bytes will note be included
…mail.nr into audit/duplicate-code
…ength to actual length
…tion for function naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://veridise.notion.site/11f105edf1db810a878fc7266a62571a?v=14a105edf1db80928576000c9403f10b&p=13f105edf1db800d88b1c610ce5600c9&pm=s
Apply suggestions removing unused code. Note: most of these were handled in prs prior to reading this specific issue on the notion. The
msg_u8_to_u32()suggestion was not applied due to the fact block size isn't likely to change given the hash function currently used is sha256 and block size will remain 64 bytesStack order: 10