feat: Add SHA precompute for QP-encoded selectors #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
SoraSuegami
reviewed
Dec 12, 2024
Comment on lines
+58
to
+59
| const cleanString = new TextDecoder().decode(cleanContent); | ||
| const selectorIndex = cleanString.indexOf(selector); |
There was a problem hiding this comment.
@devin-ai-integration
Do these lines work even if cleanContent contains multi-bytes characters in UTF8?
feat: Add SHA precompute for QP-encoded selectors
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
SoraSuegami
had a problem deploying
to
development
GitHub Actions
Failure
SoraSuegami
temporarily deployed
to
development
GitHub Actions
Inactive
SoraSuegami
temporarily deployed
to
development
GitHub Actions
Inactive
SoraSuegami
had a problem deploying
to
development
GitHub Actions
Failure
shreyas-londhe
force-pushed
the
feat/qp-precompute-selector
branch
from
27f29c5 to
13d6e82
Compare
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add SHA precompute for QP-encoded selectors
This PR improves the handling of Quoted-Printable (QP) encoded content in email bodies and selectors:
The changes ensure that selectors containing UTF-8 characters (like em dash) are correctly matched in QP-encoded email bodies.
Link to Devin run: https://app.devin.ai/sessions/72a6c7a05a7649df998d07c84a387996