Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New yarn.lock and fix circuit packages #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

numtel
Copy link

@numtel numtel commented Oct 12, 2024

Yarn install fails on fresh clone:

Screenshot from 2024-10-12 01-16-50

The version pinning on packages/circuits/package.json is because the interface has changed in the current 6.1.6 version:

    Error: Command failed: circom --wasm -l /home/ben/pot/packages/circuits/node_modules -l /home/ben/pot/node_modules --sym --r1cs --output /home/ben/pot/packages/circuits/build/twitter /home/ben/pot/packages/circuits/src/twitter.circom
    error[T2012]: Calling function with wrong number of arguments
       ┌─ "/home/ben/pot/packages/circuits/src/twitter.circom":46:20
       │
    46 │     component EV = EmailVerifier(maxHeadersLength, maxBodyLength, n, k, 0);
       │                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Got 5 params, 8 where expected
    
    previous errors were found

Circuit and contract tests pass:

packages/circuits$ yarn test
 PASS  tests/twitter.test.ts (263.5 s)
  Twitter email test
    ✓ should verify twitter email (99503 ms)
    ✓ should fail if the twitterUsernameIndex is invalid (4026 ms)
    ✓ should fail if the twitterUsernameIndex is out of bounds (3995 ms)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        263.527 s
Ran all test suites.

packages/contracts$ yarn test
[⠊] Compiling...
No files changed, compilation skipped

Ran 5 tests for test/TestTwitter.t.sol:TwitterUtilsTest
[PASS] testChainID() (gas: 3076)
[PASS] testSVG() (gas: 2028360)
[PASS] testUnpack1() (gas: 25418)
[PASS] testUnpack2() (gas: 27763)
[PASS] testVerifyTestEmail() (gas: 674549)
Suite result: ok. 5 passed; 0 failed; 0 skipped; finished in 79.71ms (95.86ms CPU time)

Ran 1 test suite in 88.70ms (79.71ms CPU time): 5 tests passed, 0 failed, 0 skipped (5 total tests)

Copy link

vercel bot commented Oct 12, 2024

@numtel is attempting to deploy a commit to the eeshau's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant