Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce current stylua style #172

Merged
merged 1 commit into from
Jun 23, 2024
Merged

enforce current stylua style #172

merged 1 commit into from
Jun 23, 2024

Conversation

tjex
Copy link
Member

@tjex tjex commented Jun 22, 2024

During #171 I noticed that the call_parenthesis stylua setting had not been set in stylua.toml.

Updated the stylua.toml file accordingly in keeping with the current formatting in the project and formatted the whole project.

I added a line length of 110 as a sane default (and personal preference).
It's fairly arguable to have some hard setting for line length to catch future contributions with line wrap on?..

format project with enforced stylua settings
@tjex tjex requested a review from kabouzeid June 22, 2024 12:05
@tjex tjex merged commit 48dbb00 into zk-org:main Jun 23, 2024
@tjex
Copy link
Member Author

tjex commented Jun 24, 2024

err. I guess I just found out by accident that I can push directly to this repo!.. Because I def didn't merge this myself. I guess GitHub resolves PRs if the commit is pushed to the same branch which is being merged into..?

Anyway. If this change was not ok, then ping me back here and I'll revert it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant